irq: phytium: update phytium irq controller driver support to 6.6.0.4

[wangchenlu2236]

This patches updates the support for phytium irq controller driver.

1.iommu/arm-smmu: Add SMMU workaround for Phytium Ps17064
2.arm64: Phytium: Slove the error on aarch32 compiler
3.arm64: Phytium: Fix incorrect MSI compose logic on Phytium PS17064 SoCs

Summary by Sourcery

Update IOMMU, SMMU, and GICv3 ITS handling to apply Phytium PS17064-specific workarounds and defaults.

Bug Fixes:

• Force IOMMU default domain to identity and enable passthrough on Phytium PS17064 SoCs to avoid issues introduced by the SMMU workaround.
• Adjust SMMU device probing on Phytium PS17064 by rewriting firmware IDs to match expected stream IDs.
• Prevent incorrect MSI message composition on Phytium PS17064 by skipping the IOMMU-backed MSI composition path for that CPU model.

Enhancements:

• Introduce Phytium-specific CPU model checks and helper macro wiring in the IOMMU and SMMU drivers to support PS17064 workarounds.

[sourcery-ai]

Reviewer's Guide

Updates Phytium PS17064-specific handling in the IOMMU core, ARM SMMU driver, and GICv3 ITS MSI composition path to implement a SoC-specific SMMU workaround and avoid faulty MSI/IOMMU interactions on Phytium SoCs.

Sequence diagram for MSI message composition on Phytium PS17064

sequenceDiagram
    participant DeviceDriver
    participant GICv3_ITS as its_irq_compose_msi_msg
    participant IOMMU_DMA as iommu_dma_compose_msi_msg

    DeviceDriver->>GICv3_ITS: its_irq_compose_msi_msg(irq_data, msg)
    GICv3_ITS->>GICv3_ITS: its_get_event_id(irq_data)
    GICv3_ITS->>GICv3_ITS: read_cpuid_id()
    alt [CPU model != MIDR_PHYTIUM_PS17064]
        GICv3_ITS->>IOMMU_DMA: iommu_dma_compose_msi_msg(msi_desc, msg)
    else [CPU model == MIDR_PHYTIUM_PS17064]
        GICv3_ITS-->>DeviceDriver: return without calling IOMMU_DMA
    end

Loading

Sequence diagram for IOMMU default domain selection on Phytium PS17064

sequenceDiagram
    participant Kernel as kernel_init
    participant IOMMUCore as iommu_subsys_init
    participant CPU as read_cpuid_id

    Kernel->>IOMMUCore: iommu_subsys_init()
    IOMMUCore->>CPU: read_cpuid_id()
    CPU-->>IOMMUCore: midr
    alt [midr & MIDR_CPU_MODEL_MASK == MIDR_PHYTIUM_PS17064]
        IOMMUCore->>IOMMUCore: iommu_set_default_passthrough(true)
    else [other SoCs]
        IOMMUCore->>IOMMUCore: iommu_set_default_translated()<br/>iommu_set_default_passthrough(false)
    end

Loading

File-Level Changes

Change	Details	Files
Force IOMMU default domain to IDENTITY and passthrough on Phytium PS17064 SoCs, overriding global or cmdline defaults to align with SMMU workaround needs.	Include <asm/cputype.h> in the IOMMU core when CONFIG_ARCH_PHYTIUM is enabled to allow CPU model detection. In iommu_subsys_init(), detect MIDR_PHYTIUM_PS17064 via read_cpuid_id() and force iommu_set_default_passthrough(true) regardless of global iommu.passthrough defaults. In iommu_set_def_domain_type(), detect MIDR_PHYTIUM_PS17064 and override iommu_def_domain_type to IOMMU_DOMAIN_IDENTITY while forcing default passthrough, short-circuiting further processing of the parameter.	drivers/iommu/iommu.c
Add an ARM SMMU device-ID rewriting workaround for Phytium PS17064 to adjust firmware-provided IDs before standard SMMU stream ID handling.	Include <asm/cputype.h> in the ARM SMMU driver header to allow CPU model detection. Define a Phytium-only FWID_READ() macro to transform firmware-provided IDs into the layout expected by the hardware/driver. In arm_smmu_probe_device(), when running on MIDR_PHYTIUM_PS17064, iterate over fwspec->ids, transform each ID via FWID_READ, and add the rewritten IDs back to the IOMMU fwspec prior to the normal probe path.	drivers/iommu/arm/arm-smmu/arm-smmu.c drivers/iommu/arm/arm-smmu/arm-smmu.h
Prevent IOMMU MSI message composition on Phytium PS17064 SoCs in the GICv3 ITS driver to avoid incorrect MSI address/data setup.	In its_irq_compose_msi_msg(), after computing the ITS base MSI address and data, detect MIDR_PHYTIUM_PS17064 via read_cpuid_id() and, when matched, return early without invoking iommu_dma_compose_msi_msg().	drivers/irqchip/irq-gic-v3-its.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign avenger-285714 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deepin-ci-robot]

Hi @wangchenlu2236. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sourcery-ai]

Hey - I've left some high level feedback:

• The Phytium PS17064 CPU model check using read_cpuid_id() & MIDR_CPU_MODEL_MASK is duplicated across multiple files; consider factoring this into a shared helper or macro so future model handling changes only need to be made in one place.
• In iommu_set_def_domain_type(), the Phytium-specific block silently overrides the user-specified default domain; it would be helpful to emit a pr_info/pr_warn explaining that the requested setting is being ignored on PS17064 due to the SMMU workaround.
• In arm_smmu_probe_device(), the loop invoking iommu_fwspec_add_ids() for the Phytium workaround does not check the return value and may create duplicate or unexpected IDs; consider handling the return code and/or documenting the expected resulting ID list to avoid subtle fwspec corruption.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The Phytium PS17064 CPU model check using `read_cpuid_id() & MIDR_CPU_MODEL_MASK` is duplicated across multiple files; consider factoring this into a shared helper or macro so future model handling changes only need to be made in one place.
- In `iommu_set_def_domain_type()`, the Phytium-specific block silently overrides the user-specified default domain; it would be helpful to emit a `pr_info`/`pr_warn` explaining that the requested setting is being ignored on PS17064 due to the SMMU workaround.
- In `arm_smmu_probe_device()`, the loop invoking `iommu_fwspec_add_ids()` for the Phytium workaround does not check the return value and may create duplicate or unexpected IDs; consider handling the return code and/or documenting the expected resulting ID list to avoid subtle fwspec corruption.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Copilot]

Pull request overview

This PR adds Phytium PS17064-specific workarounds across the IOMMU/SMMU and GICv3 ITS paths to adjust default IOMMU behavior, stream IDs, and MSI message composition.

Changes:

• Forces default IOMMU passthrough/identity behavior on PS17064.
• Adds PS17064 SMMU firmware ID adjustment during device probing.
• Skips IOMMU-backed MSI message composition for PS17064 ITS interrupts.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
drivers/irqchip/irq-gic-v3-its.c	Adds PS17064-specific early return before IOMMU MSI composition.
drivers/iommu/iommu.c	Forces default IOMMU passthrough behavior for PS17064.
drivers/iommu/arm/arm-smmu/arm-smmu.h	Adds CPU type include and Phytium FWID transformation macro.
drivers/iommu/arm/arm-smmu/arm-smmu.c	Applies Phytium FWID workaround during SMMU device probing.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.