Skip to content

[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] ACPI: resource: Use IRQ override on MACHENIKE 16P#842

Merged
Avenger-285714 merged 1 commit into
deepin-community:linux-6.6.yfrom
opsiff:linux-6.6.y-2025-06-03-acpi
Jun 3, 2025
Merged

[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] ACPI: resource: Use IRQ override on MACHENIKE 16P#842
Avenger-285714 merged 1 commit into
deepin-community:linux-6.6.yfrom
opsiff:linux-6.6.y-2025-06-03-acpi

Conversation

@opsiff
Copy link
Copy Markdown
Member

@opsiff opsiff commented Jun 3, 2025

Use ACPI IRQ override on MACHENIKE laptop to make the internal keyboard work.

Add a new entry to the irq1_edge_low_force_override structure, similar to the existing ones.

Link: https://bbs.deepin.org.cn/zh/post/287628

Summary by Sourcery

Bug Fixes:

  • Add ACPI IRQ override entry for MACHENIKE L16P in irq1_edge_low_force_override table

Use ACPI IRQ override on MACHENIKE laptop to make the internal
keyboard work.

Add a new entry to the irq1_edge_low_force_override structure, similar
to the existing ones.

Link: https://bbs.deepin.org.cn/zh/post/287628
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 3, 2025

Reviewer's Guide

Appends a new DMI system ID to irq1_edge_low_force_override in drivers/acpi/resource.c to enable ACPI IRQ override on MACHENIKE L16P, restoring internal keyboard functionality.

File-Level Changes

Change Details Files
Added DMI entry for MACHENIKE L16P to the IRQ override table
  • Inserted a new DMI system_id struct
  • Matched DMI_SYS_VENDOR 'MACHENIKE' and DMI_BOARD_NAME 'L16P'
drivers/acpi/resource.c

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • 新增的DMI匹配项缺少对应的注释说明,应添加以解释其用途和匹配条件。
  • 检查是否有必要在新增DMI匹配项后更新相关的文档或配置文件,以确保一致性。

是否建议立即修改:

@deepin-ci-robot deepin-ci-robot requested review from huangbibo and myml June 3, 2025 02:42
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @opsiff - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Avenger-285714
Copy link
Copy Markdown
Member

upstream

@Avenger-285714
Copy link
Copy Markdown
Member

/approve

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Avenger-285714

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Avenger-285714
Copy link
Copy Markdown
Member

/lgtm

@Avenger-285714 Avenger-285714 merged commit 33766a3 into deepin-community:linux-6.6.y Jun 3, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants