fix(security): harden daemon auth boundaries#266
Open
TheusHen wants to merge 1 commit into
Open
Conversation
Refuse unauthenticated non-loopback controller binds and stop clap from printing FORKD_TOKEN values in help output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This tightens two security edges that are easy to miss in day-to-day use:
0.0.0.0,::, etc.) instead of only logging a warningFORKD_TOKENvalue in help output when the token is supplied via envBoth keep the local dev path boring: loopback without a token still works, and authenticated network binds still work.
Why
These are trust-boundary footguns:
Checks
cargo fmt --checkcargo test -p forkd-cli -p forkd-controllercargo clippy -p forkd-cli -p forkd-controller -- -D warningsFORKD_TOKEN=pony-secret-token-123 forkd ls --helpdoes not print the token valueforkd-controller serve --bind 0.0.0.0:8899without--token-fileexits withrefusing unauthenticated non-loopback bind