Skip to content

Commit 8e5d457

Browse files
Critsium-xyclaude
andauthored
Refactor: move version.h from source_main to source_base (#7611)
version.h is a leaf header (a single VERSION macro) with no dependencies, but it lived in source_main (the top-level entry layer). This forced source_io to include upward into source_main (edge source_io -> source_main), a reverse dependency that violates the intended module layering. Move it to source_base (L0 infrastructure), which every module may depend on, and update the 6 include sites. No behavior change; header-only, so no CMake changes are needed (resolved via the existing source/ include root). This cuts the source_io -> source_main reverse edge. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 8e99806 commit 8e5d457

7 files changed

Lines changed: 6 additions & 6 deletions

File tree

source/source_io/module_json/general_info.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
#include "para_json.h"
44
#include "abacusjson.h"
55
#include "source_base/parallel_global.h"
6-
#include "source_main/version.h"
6+
#include "source_base/version.h"
77

88
// Add json objects to gener_info
99
namespace Json

source/source_io/module_json/test/para_json_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include "source_io/module_json/readin_info.h"
88
#include "source_io/module_parameter/parameter.h"
99
#include "source_io/module_json/para_json.h"
10-
#include "source_main/version.h"
10+
#include "source_base/version.h"
1111
#undef private
1212
/************************************************
1313
* unit test of json output module

source/source_io/parse_args.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include <string>
99

1010
#include "module_parameter/read_input.h"
11-
#include "source_main/version.h"
11+
#include "source_base/version.h"
1212

1313
#if defined(COMMIT_INFO)
1414
#include "commit.h"

source/source_io/test/parse_args_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#include "source_io/parse_args.h"
22
#include "gtest/gtest.h"
33
#include "source_io/module_parameter/read_input.h"
4-
#include "source_main/version.h"
4+
#include "source_base/version.h"
55

66
// Already deal with Testing.cmake
77
// #include "build_info.h"

source/source_main/driver.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#include "source_io/module_output/print_info.h"
1111
#include "source_io/module_parameter/read_input.h"
1212
#include "source_io/module_parameter/parameter.h"
13-
#include "source_main/version.h"
13+
#include "source_base/version.h"
1414
#include "source_base/parallel_global.h"
1515
#ifdef __DSP
1616
#include "source_base/module_device/memory_op.h"

source/source_main/main.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include "source_base/parallel_global.h"
99
#include "source_io/parse_args.h"
1010
#include "source_io/module_parameter/parameter.h"
11-
#include "source_main/version.h"
11+
#include "source_base/version.h"
1212
#ifdef _OPENMP
1313
#include <omp.h>
1414
#endif

0 commit comments

Comments
 (0)