Merge branch 'develop' into 2026-07-01

Author: mohanchen

.coderabbit.yaml

@@ -15,6 +15,10 @@ reviews:
         Focus on newly introduced GlobalV/GlobalC/PARAM dependencies, default
         parameters in headers, module placement, CMakeLists.txt linkage, C++11
         compatibility, and focused tests for behavior changes.
+        During the legacy global-state migration period, treat a net increase in
+        GlobalV/GlobalC/PARAM code references as blocking, and treat
+        migration-neutral added usage as reviewer-visible warnings requiring
+        reason, scope, risk, and cleanup rationale.
     - path: "source/source_io/module_parameter/**"
       instructions: |
         Treat INPUT parameter metadata, parsing, defaults, descriptions, and

.gitattributes

@@ -10,4 +10,4 @@ CASES_*.txt text eol=lf
 .gitignore export-ignore
 .gitmodules export-ignore
 .pre-commit-config.yaml export-ignore
-.github/ export-ignore
+.github export-ignore

.github/instructions/abacus-governance.instructions.md

@@ -12,7 +12,9 @@ Apply these instructions when reviewing or changing ABACUS code:
   newly introduced symbols, and changed text files for line-ending checks.
 - Do not treat untouched historical debt as a default blocker. Mention it only
   when it affects the changed area, and label it as advisory.
-- Flag newly introduced `GlobalV`, `GlobalC`, or `PARAM` cross-layer control.
+- Flag PRs that increase `GlobalV`, `GlobalC`, or `PARAM` code references as
+  blocker-level governance issues. Flag migration-neutral added usage as a
+  warning that requires reason, scope, risk, and cleanup/follow-up rationale.
   Prefer explicit dependencies or narrow local interfaces.
 - Flag new default arguments in existing header interfaces. Prefer explicit
   call-site updates, overloads, or a clearer configuration object.

.github/pull_request_template.md

@@ -8,44 +8,17 @@
 - [ ] I have requested any needed governance exception below.
 
 ### Linked Issue
-Fix #...
+Fix #
 
 ### Unit Tests and/or Case Tests for my changes
-- A unit test is added for each new feature or bug fix.
-
-### Exact Verification Performed
 - Commands run:
 - Result summary:
 - Checks not run, with reason:
 
 ### What's changed?
-- Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...
-
-### Governance Checklist
-- Global dependencies: no new `GlobalV`, `GlobalC`, or `PARAM` cross-layer control, or exception requested below.
-- Default parameters: no new default arguments added to existing interfaces, or exception requested below.
-- Headers: no unnecessary header dependencies or `.hpp` propagation, or rationale provided below.
-- Line endings: text files use LF; only `.bat` and `.cmd` use CRLF.
-- Build linkage: new source files are listed in the relevant `CMakeLists.txt`, or rationale provided below.
-- Documentation: behavior/interface changes include documentation updates, or no documentation update is required because ...
-- CodeRabbit: if automatic review has not started and the repository has CodeRabbit installed, request `@coderabbitai review`.
-
-### INPUT Parameter Changes
-- Parameters added/removed/changed:
-- `docs/parameters.yaml` updated: yes/no/not applicable
-- `docs/advanced/input_files/input-main.md` updated: yes/no/not applicable
-- If not updated, explain why no INPUT documentation update is required:
-
-### Core Module Impact
-- Affected core modules:
-- Risk summary:
-- Compatibility or performance impact:
+- Example: brief summary of the user-visible or developer-facing change.
 
-### Governance Exception
-- Rule:
-- Reason:
-- Scope:
-- User or maintenance risk:
-- Why the normal rule cannot be followed now:
-- Follow-up cleanup plan:
-- Requested approver:
+### Governance Notes
+- INPUT/docs changes:
+- Core module impact:
+- Exceptions requested:

.github/workflows/agent_governance.yml

@@ -7,14 +7,15 @@ on:
 permissions:
   contents: read
   pull-requests: read
+  issues: write
 
 jobs:
   governance:
     name: Governance checks
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v7
         with:
           fetch-depth: 0
 
@@ -53,3 +54,40 @@ jobs:
         if: always()
         run: |
           cat agent_governance_summary.md >> "$GITHUB_STEP_SUMMARY"
+
+      - name: Comment governance warnings
+        if: >-
+          always() &&
+          github.event.pull_request.head.repo.full_name == github.repository
+        env:
+          GH_TOKEN: ${{ github.token }}
+          PR_NUMBER: ${{ github.event.pull_request.number }}
+        run: |
+          if ! grep -qi '^| warning |' agent_governance_summary.md; then
+            exit 0
+          fi
+
+          marker='<!-- agent-governance-warning -->'
+          body_file="$(mktemp)"
+          json_file="$(mktemp)"
+          {
+            echo "$marker"
+            echo
+            cat agent_governance_summary.md
+          } > "$body_file"
+          jq -Rs '{body: .}' < "$body_file" > "$json_file"
+
+          existing_comment_id="$(gh api --paginate \
+            "repos/${GITHUB_REPOSITORY}/issues/${PR_NUMBER}/comments" \
+            --jq ".[] | select(.body | contains(\"${marker}\")) | .id" \
+            | head -n 1)"
+
+          if [ -n "$existing_comment_id" ]; then
+            gh api --method PATCH \
+              "repos/${GITHUB_REPOSITORY}/issues/comments/${existing_comment_id}" \
+              --input "$json_file"
+          else
+            gh api --method POST \
+              "repos/${GITHUB_REPOSITORY}/issues/${PR_NUMBER}/comments" \
+              --input "$json_file"
+          fi

.github/workflows/build_test_cmake.yml

@@ -23,11 +23,11 @@ jobs:
 
           - tag: gnu
             external_toolchain_args: ""
-            build_args: "-DENABLE_LIBXC=ON -DENABLE_MLALGO=ON -DENABLE_LIBRI=ON"
+            build_args: "-DENABLE_LIBXC=ON -DENABLE_MLALGO=ON -DENABLE_LIBRI=ON -DENABLE_DFTD4=ON"
             name: "Build extra components with GNU toolchain"
           - tag: intel
             external_toolchain_args: "--with-intel"
-            build_args: "-DENABLE_LIBXC=ON -DENABLE_PEXSI=ON -DENABLE_MLALGO=ON -DENABLE_LIBRI=ON"
+            build_args: "-DENABLE_LIBXC=ON -DENABLE_PEXSI=ON -DENABLE_MLALGO=ON -DENABLE_LIBRI=ON -DENABLE_DFTD4=ON"
             name: "Build extra components with Intel toolchain"
 
           - tag: cuda