You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/pull_request_template.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -22,7 +22,7 @@ Fix #...
22
22
- Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...
23
23
24
24
### Governance Checklist
25
-
- Global dependencies: no new `GlobalV`, `GlobalC`, or `PARAM`cross-layer control, or exception requested below.
25
+
- Global dependencies: no net increase in `GlobalV`, `GlobalC`, or `PARAM`code references, or exception requested below with reason, scope, risk, and cleanup plan.
26
26
- Default parameters: no new default arguments added to existing interfaces, or exception requested below.
27
27
- Headers: no unnecessary header dependencies or `.hpp` propagation, or rationale provided below.
28
28
- Line endings: text files use LF; only `.bat` and `.cmd` use CRLF.
Copy file name to clipboardExpand all lines: docs/developers_guide/agent_governance.md
+8-1Lines changed: 8 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -69,7 +69,7 @@ decisions.
69
69
| --- | --- | --- | --- | --- | --- | --- | --- |
70
70
| Basic text format | LF line endings | phase-one mechanical | hook + CI | medium | block | full changed text file |`.bat` and `.cmd` keep CRLF |
71
71
| Language baseline | C++11 compatibility | build/toolchain | CI | high | block | build/static tooling | Actual compiler/toolchain result wins |
72
-
|New global dependency | Added `GlobalV`/`GlobalC`/`PARAM`as cross-layer control | phase-one mechanical + AI review | CI + AI review | high | block | added code lines | Historical untouched usage and documentation mentions are not blocked |
72
+
|Global dependency budget | Net increase of `GlobalV`/`GlobalC`/`PARAM`references in code diff | phase-one mechanical + AI review | CI + AI review | high | block on net increase, warn on non-increasing added usage | added and removed code lines | Historical untouched usage and documentation mentions are not blocked; migration-neutral moves require reviewer rationale|
73
73
| New default parameter | Header declaration adds a default argument | phase-one mechanical + AI review | CI + AI review | high | block | header diff | High misuse risk |
74
74
|`.hpp` propagation | New `.hpp` or header includes `.hpp`| phase-one mechanical warning | CI + AI review | medium | warn | new files and added includes | Exception can be recorded in PR |
75
75
| Header dependency growth | Header diff adds includes | phase-one mechanical warning + AI review | CI + AI review | medium | warn | added header includes | Necessity is semantic and not mechanically decided |
@@ -97,6 +97,13 @@ explicit governance change. For header include warnings, the rationale should
97
97
state whether the header needs a complete type, for example because it owns a
98
98
value member rather than a pointer or reference.
99
99
100
+
For global dependencies, the mechanical checker uses a PR-level budget during
101
+
the legacy migration period. A PR blocks only when the number of code references
102
+
to `GlobalV`, `GlobalC`, or `PARAM` increases after accounting for deleted
103
+
references. If a PR adds global references while deleting at least as many
104
+
elsewhere, the checker warns instead of blocking; reviewers should confirm the
105
+
change is a migration-neutral move or part of a cleanup path.
0 commit comments