Skip to content

Commit f22653d

Browse files
committed
Restore Reminder-style PR checklist
1 parent 7e99bc9 commit f22653d

2 files changed

Lines changed: 39 additions & 5 deletions

File tree

.github/pull_request_template.md

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
1-
### Checklist
2-
- [ ] I have linked an issue or explained why none is needed.
3-
- [ ] I have listed verification commands/results, or explained why checks were not run.
4-
- [ ] I have described user-visible, INPUT/docs, or core-module impact if applicable.
5-
- [ ] I have noted any governance exception needed for this PR.
1+
### Reminder
2+
- [ ] I have read `AGENTS.md` and `docs/developers_guide/agent_governance.md`.
3+
- [ ] I have linked an issue or explained why this PR does not need one.
4+
- [ ] I have added adequate unit tests and/or case tests, or explained why not.
5+
- [ ] I have listed the exact verification commands run and their results.
6+
- [ ] I have described user-visible behavior changes, including INPUT parameter changes.
7+
- [ ] I have explained core-module impact for ESolver, HSolver, ElecState, Hamilt, Operator, Psi, or other `source/` changes.
8+
- [ ] I have requested any needed governance exception below.
69

710
### Linked Issue
811
Fix #

tools/03_code_analysis/test_agent_governance_check.py

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -343,6 +343,37 @@ def test_accepts_core_pr_template_fields_from_event_payload(self):
343343
self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
344344
self.assertNotIn("PR metadata completeness", result.stdout)
345345

346+
def test_accepts_reminder_style_pr_template_from_event_payload(self):
347+
event = self.repo / "event.json"
348+
event.write_text(
349+
json.dumps(
350+
{
351+
"pull_request": {
352+
"body": "### Reminder\n"
353+
"- [ ] I have read `AGENTS.md` and `docs/developers_guide/agent_governance.md`.\n"
354+
"- [ ] I have linked an issue or explained why this PR does not need one.\n"
355+
"- [ ] I have added adequate unit tests and/or case tests, or explained why not.\n"
356+
"- [ ] I have listed the exact verification commands run and their results.\n"
357+
"- [ ] I have described user-visible behavior changes, including INPUT parameter changes.\n"
358+
"- [ ] I have explained core-module impact for ESolver, HSolver, ElecState, Hamilt, Operator, Psi, or other `source/` changes.\n"
359+
"- [ ] I have requested any needed governance exception below.\n\n"
360+
"### Linked Issue\nNo issue; governance bootstrap.\n\n"
361+
"### Unit Tests and/or Case Tests for my changes\n"
362+
"Ran python3 -m unittest tools/03_code_analysis/test_agent_governance_check.py.\n\n"
363+
"### What's changed?\n"
364+
"Adds governance checks only; no runtime behavior change.\n\n"
365+
"### Governance Notes\n"
366+
"No INPUT, core module, or exception notes.\n"
367+
}
368+
}
369+
)
370+
)
371+
372+
result = self.run_checker("--event-path", str(event))
373+
374+
self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
375+
self.assertNotIn("PR metadata completeness", result.stdout)
376+
346377
def test_warns_for_source_change_without_test_evidence(self):
347378
self.write("source/source_base/new_feature.cpp", "int new_feature() { return 1; }\n")
348379
self.write("source/source_base/CMakeLists.txt", "add_library(new_feature new_feature.cpp)\n")

0 commit comments

Comments
 (0)