Commit 2d80dcd
Han Wang
fix(tf2): apply model-level pair_exclude at nlist BUILD; align io test
Replace the bespoke test_pair_exclude_savedmodel.py with an aligned
IOTest subclass (TestDeepPotPairExclude) in test_io.py: it supplies only
the model dict and inherits test_data_equal / test_deep_eval, which export
through every backend and cross-compare at rtol/atol 1e-12 (with the built-in
all-NaN skip covering the numpy dpmodel force path). Gated on
DP_TEST_TF2_ONLY, the mode in which test_deep_eval exercises the jax2tf
'.savedmodel' path -- the TF v1 backend raises NotImplementedError on
pair_exclude_types, so it must not run there.
That aligned cross-backend eval exposed a real gap: the tf2 backend
('.savedmodeltf') silently ignored model-level pair_exclude_types (its
SavedModel returned the non-excluded energy 2.847 vs the correct 2.843).
tf2 was outside the original PR scope (dpmodel/pt_expt/jax) and its outer
TF wrapper (deepmd/tf2/make_model.py) never folded the exclusion into the
nlist. Fix it the same way as every other backend: thread pair_excl into
model_call_from_call_lower and apply the canonical dpmodel
apply_pair_exclusion_nlist at the nlist-BUILD seam (the tensors are already
ndtensorflow arrays, so no wrap/unwrap). All five backends now agree.1 parent d182628 commit 2d80dcd
4 files changed
Lines changed: 82 additions & 172 deletions
File tree
- deepmd/tf2
- utils
- source/tests/consistent/io
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
34 | 40 | | |
35 | 41 | | |
36 | 42 | | |
| |||
56 | 62 | | |
57 | 63 | | |
58 | 64 | | |
| 65 | + | |
59 | 66 | | |
60 | 67 | | |
61 | 68 | | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
62 | 76 | | |
63 | 77 | | |
64 | 78 | | |
| |||
126 | 140 | | |
127 | 141 | | |
128 | 142 | | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
129 | 152 | | |
130 | 153 | | |
131 | 154 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
377 | 377 | | |
378 | 378 | | |
379 | 379 | | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
380 | 383 | | |
381 | 384 | | |
382 | 385 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
311 | 311 | | |
312 | 312 | | |
313 | 313 | | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
Lines changed: 0 additions & 172 deletions
This file was deleted.
0 commit comments