Fix cross-platform compatibility for directory creation and path handling

Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>

Author: Copilot

PYTORCH_PROFILER_INTEGRATION.md doc/development/pytorch-profiler.mdPYTORCH_PROFILER_INTEGRATION.md renamed to doc/development/pytorch-profiler.md

@@ -173,11 +173,26 @@ void get_env_nthreads(int& num_intra_nthreads, int& num_inter_nthreads);
 void get_env_pytorch_profiler(bool& enable_profiler, std::string& output_dir);
 
 /**
- * @brief Get MPI rank if MPI is available and initialized, otherwise return 0.
- * @return The MPI rank or 0 if MPI is not available/initialized.
+ * @brief Get MPI rank if MPI is available and initialized, otherwise return -1.
+ * @return The MPI rank or -1 if MPI is not available/initialized.
  **/
 int get_mpi_rank();
 
+/**
+ * @brief Create directories recursively in a cross-platform way.
+ * @param path The path to create.
+ * @return true if successful or directory already exists, false otherwise.
+ **/
+bool create_directories(const std::string& path);
+
+/**
+ * @brief Join two path components using platform-appropriate separator.
+ * @param path1 The first path component.
+ * @param path2 The second path component.
+ * @return The joined path.
+ **/
+std::string join_path(const std::string& path1, const std::string& path2);
+
 /**
  * @brief Dynamically load OP library. This should be called before loading
  * graphs.

source/api_cc/include/common.h

@@ -115,8 +115,9 @@ void DeepPotPT::init(const std::string& model,
   if (profiler_enabled) {
 #ifdef BUILD_PYTORCH
     // Create output directory if it doesn't exist
-    std::string mkdir_cmd = "mkdir -p " + profiler_output_dir;
-    std::system(mkdir_cmd.c_str());
+    if (!create_directories(profiler_output_dir)) {
+      std::cerr << "Warning: Failed to create profiler output directory: " << profiler_output_dir << std::endl;
+    }
 
     std::cout << "PyTorch profiler enabled. Output directory: " << profiler_output_dir << std::endl;
     // Start profiling using new API
@@ -147,10 +148,10 @@ DeepPotPT::~DeepPotPT() {
       std::string output_file;
       if (rank >= 0) {
         // MPI is available and initialized, include rank in filename
-        output_file = profiler_output_dir + "/pytorch_profiler_trace_rank" + std::to_string(rank) + ".json";
+        output_file = join_path(profiler_output_dir, "pytorch_profiler_trace_rank" + std::to_string(rank) + ".json");
       } else {
         // MPI not available or not initialized, use original filename
-        output_file = profiler_output_dir + "/pytorch_profiler_trace.json";
+        output_file = join_path(profiler_output_dir, "pytorch_profiler_trace.json");
       }
       profiler_result = torch::profiler::disableProfiler();
       if (profiler_result) {

source/api_cc/src/DeepPotPT.cc

@@ -115,8 +115,9 @@ void DeepSpinPT::init(const std::string& model,
   if (profiler_enabled) {
 #ifdef BUILD_PYTORCH
     // Create output directory if it doesn't exist
-    std::string mkdir_cmd = "mkdir -p " + profiler_output_dir;
-    std::system(mkdir_cmd.c_str());
+    if (!create_directories(profiler_output_dir)) {
+      std::cerr << "Warning: Failed to create profiler output directory: " << profiler_output_dir << std::endl;
+    }
 
     std::cout << "PyTorch profiler enabled. Output directory: " << profiler_output_dir << std::endl;
     // Start profiling using new API
@@ -147,10 +148,10 @@ DeepSpinPT::~DeepSpinPT() {
       std::string output_file;
       if (rank >= 0) {
         // MPI is available and initialized, include rank in filename
-        output_file = profiler_output_dir + "/pytorch_profiler_trace_rank" + std::to_string(rank) + ".json";
+        output_file = join_path(profiler_output_dir, "pytorch_profiler_trace_rank" + std::to_string(rank) + ".json");
       } else {
         // MPI not available or not initialized, use original filename
-        output_file = profiler_output_dir + "/pytorch_profiler_trace.json";
+        output_file = join_path(profiler_output_dir, "pytorch_profiler_trace.json");
       }
       profiler_result = torch::profiler::disableProfiler();
       if (profiler_result) {

source/api_cc/src/DeepSpinPT.cc

@@ -7,6 +7,9 @@
 #include <fstream>
 #include <sstream>
 #include <string>
+#include <iostream>
+#include <sys/stat.h>
+#include <errno.h>
 
 // Try to include MPI if available - this will be a no-op if MPI is not available
 #ifdef __has_include
@@ -27,6 +30,7 @@
 #define PSAPI_VERSION 2
 #include <io.h>
 #include <windows.h>
+#include <direct.h>  // for _mkdir
 #define O_RDONLY _O_RDONLY
 #else
 // not windows
@@ -419,6 +423,50 @@ int deepmd::get_mpi_rank() {
   return rank;
 }
 
+bool deepmd::create_directories(const std::string& path) {
+  if (path.empty()) {
+    return false;
+  }
+  
+  // Check if directory already exists
+  struct stat st;
+  if (stat(path.c_str(), &st) == 0) {
+    return S_ISDIR(st.st_mode);
+  }
+  
+  // Find the parent directory
+  size_t pos = path.find_last_of("/\\");
+  if (pos != std::string::npos && pos > 0) {
+    std::string parent = path.substr(0, pos);
+    if (!create_directories(parent)) {
+      return false;
+    }
+  }
+  
+  // Create this directory
+#if defined(_WIN32)
+  return _mkdir(path.c_str()) == 0 || errno == EEXIST;
+#else
+  return mkdir(path.c_str(), 0755) == 0 || errno == EEXIST;
+#endif
+}
+
+std::string deepmd::join_path(const std::string& path1, const std::string& path2) {
+  if (path1.empty()) return path2;
+  if (path2.empty()) return path1;
+  
+  char sep = '/';
+#if defined(_WIN32)
+  sep = '\\';
+#endif
+  
+  if (path1.back() == '/' || path1.back() == '\\') {
+    return path1 + path2;
+  } else {
+    return path1 + sep + path2;
+  }
+}
+
 static inline void _load_library_path(std::string dso_path) {
 #if defined(_WIN32)
   void* dso_handle = LoadLibrary(dso_path.c_str());