Commit a7e9fed
fix(tests): move shared test mixins to tests.common to fix DeviceContext leak (#5344)
## Summary
- Move `TestCaseSingleFrameWithNlist` and `get_tols` from
`tests.pt.model` to `tests.common.test_mixins`
- Update all pt_expt test imports to use `tests.common.test_mixins`
directly
- Simplify `tests/pt_expt/conftest.py` and remove manual
`_pop_device_contexts()` workarounds
## Root cause
`tests/pt/__init__.py` calls `torch.set_default_device("cuda:9999999")`
to enforce explicit device usage in pt tests. This pushes a
`DeviceContext` onto the torch mode stack. pt_expt descriptor/fitting
tests imported `TestCaseSingleFrameWithNlist` from
`tests.pt.model.test_env_mat`, which triggered `tests/pt/__init__.py` —
leaking the `DeviceContext` into pt_expt tests.
The leaked `DeviceContext` caused `torch.zeros()` calls (without
explicit `device=`) inside AOTInductor's lowering pass and PyTorch's
Adam optimizer to target `cuda:9999999`, crashing on CPU-only CI
machines with `AssertionError: Torch not compiled with CUDA enabled`.
## Fix
The shared mixins (`TestCaseSingleFrameWithNlist`, `get_tols`) are pure
numpy with no torch dependency. Moving them to
`tests/common/test_mixins.py` lets pt_expt tests import them without
touching the `tests.pt` package. The pt tests re-export from the common
location for backward compatibility.
## Test plan
- [x] `pytest source/tests/pt_expt/descriptor/test_se_e2_a.py` — passes,
no DeviceContext leak
- [x] `pytest source/tests/pt/model/test_env_mat.py` — passes (backward
compat via re-export)
- [x] `pytest source/tests/pt/model/test_mlp.py` — passes (backward
compat via re-export)
- [x] Broader pt_expt tests (descriptor, fitting, loss, utils) all pass
- [x] Verified: `import source.tests.pt_expt.descriptor.test_se_e2_a` no
longer creates DeviceContext
🤖 Generated with [Claude Code](https://claude.com/claude-code)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Tests**
* Consolidated shared testing utilities into a centralized module
referenced by many test suites for consistent setup and tolerance
handling
* Simplified and reduced device-context cleanup behavior in test
fixtures
* Updated numerous test imports to use the new shared testing utilities
location
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: Han Wang <wang_han@iapcm.ac.cn>1 parent 8fea5ab commit a7e9fed
File tree
22 files changed
+111
-136
lines changed- source/tests
- common
- pt_expt
- descriptor
- fitting
- loss
- utils
- pt/model
22 files changed
+111
-136
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
76 | 27 | | |
77 | 28 | | |
78 | 29 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
38 | 30 | | |
39 | 31 | | |
40 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
26 | 12 | | |
27 | 13 | | |
28 | 14 | | |
| |||
50 | 36 | | |
51 | 37 | | |
52 | 38 | | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
| 39 | + | |
58 | 40 | | |
59 | 41 | | |
60 | 42 | | |
61 | 43 | | |
62 | 44 | | |
63 | 45 | | |
64 | | - | |
65 | | - | |
| 46 | + | |
| 47 | + | |
66 | 48 | | |
67 | | - | |
68 | | - | |
69 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | 23 | | |
26 | 24 | | |
27 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | | - | |
28 | | - | |
29 | 27 | | |
30 | 28 | | |
31 | 29 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | | - | |
27 | | - | |
28 | 26 | | |
29 | 27 | | |
30 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | | - | |
30 | | - | |
31 | 29 | | |
32 | 30 | | |
33 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | 23 | | |
26 | 24 | | |
27 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | | - | |
27 | | - | |
28 | 26 | | |
29 | 27 | | |
30 | 28 | | |
| |||
0 commit comments