Skip to content

Commit bc54f07

Browse files
committed
fix(consistent): align DPA2 curated case parameter order
Match the curated DPA2 case tuples with the unpack order used by the descriptor tests so direct_dist and update_g1_has_conv map to the intended fields. Also move the regex import used for parameterized test-class name sanitization to module scope. Authored by OpenClaw (model: gpt-5.4)
1 parent 64b7a5a commit bc54f07

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

source/tests/consistent/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import inspect
33
import itertools
44
import os
5+
import re
56
import sys
67
import unittest
78
from abc import (
@@ -685,7 +686,6 @@ class TestClass(base_class):
685686
for x in pp:
686687
s = str(x)
687688
# replace non-alnum with underscore, collapse multiple underscores
688-
import re
689689
s = re.sub(r'[^a-zA-Z0-9_]', '_', s)
690690
s = re.sub(r'_+', '_', s)
691691
# remove leading/trailing underscores

source/tests/consistent/descriptor/test_dpa2.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -425,8 +425,8 @@ def data(self) -> dict:
425425
repinit_set_davg_zero,
426426
repinit_type_one_side,
427427
repinit_use_three_body,
428-
repformer_update_g1_has_conv,
429428
repformer_direct_dist,
429+
repformer_update_g1_has_conv,
430430
repformer_update_g1_has_drrd,
431431
repformer_update_g1_has_grrg,
432432
repformer_update_g1_has_attn,
@@ -525,8 +525,8 @@ def skip_pt(self) -> bool:
525525
repinit_set_davg_zero,
526526
repinit_type_one_side,
527527
repinit_use_three_body,
528-
repformer_update_g1_has_conv,
529528
repformer_direct_dist,
529+
repformer_update_g1_has_conv,
530530
repformer_update_g1_has_drrd,
531531
repformer_update_g1_has_grrg,
532532
repformer_update_g1_has_attn,
@@ -558,8 +558,8 @@ def skip_pd(self) -> bool:
558558
repinit_set_davg_zero,
559559
repinit_type_one_side,
560560
repinit_use_three_body,
561-
repformer_update_g1_has_conv,
562561
repformer_direct_dist,
562+
repformer_update_g1_has_conv,
563563
repformer_update_g1_has_drrd,
564564
repformer_update_g1_has_grrg,
565565
repformer_update_g1_has_attn,
@@ -591,8 +591,8 @@ def skip_dp(self) -> bool:
591591
repinit_set_davg_zero,
592592
repinit_type_one_side,
593593
repinit_use_three_body,
594-
repformer_update_g1_has_conv,
595594
repformer_direct_dist,
595+
repformer_update_g1_has_conv,
596596
repformer_update_g1_has_drrd,
597597
repformer_update_g1_has_grrg,
598598
repformer_update_g1_has_attn,
@@ -624,8 +624,8 @@ def skip_tf(self) -> bool:
624624
repinit_set_davg_zero,
625625
repinit_type_one_side,
626626
repinit_use_three_body,
627-
repformer_update_g1_has_conv,
628627
repformer_direct_dist,
628+
repformer_update_g1_has_conv,
629629
repformer_update_g1_has_drrd,
630630
repformer_update_g1_has_grrg,
631631
repformer_update_g1_has_attn,
@@ -701,8 +701,8 @@ def setUp(self) -> None:
701701
repinit_set_davg_zero,
702702
repinit_type_one_side,
703703
repinit_use_three_body,
704-
repformer_update_g1_has_conv,
705704
repformer_direct_dist,
705+
repformer_update_g1_has_conv,
706706
repformer_update_g1_has_drrd,
707707
repformer_update_g1_has_grrg,
708708
repformer_update_g1_has_attn,
@@ -807,8 +807,8 @@ def rtol(self) -> float:
807807
repinit_set_davg_zero,
808808
repinit_type_one_side,
809809
repinit_use_three_body,
810-
repformer_update_g1_has_conv,
811810
repformer_direct_dist,
811+
repformer_update_g1_has_conv,
812812
repformer_update_g1_has_drrd,
813813
repformer_update_g1_has_grrg,
814814
repformer_update_g1_has_attn,
@@ -846,8 +846,8 @@ def atol(self) -> float:
846846
repinit_set_davg_zero,
847847
repinit_type_one_side,
848848
repinit_use_three_body,
849-
repformer_update_g1_has_conv,
850849
repformer_direct_dist,
850+
repformer_update_g1_has_conv,
851851
repformer_update_g1_has_drrd,
852852
repformer_update_g1_has_grrg,
853853
repformer_update_g1_has_attn,
@@ -894,8 +894,8 @@ def data(self) -> dict:
894894
repinit_set_davg_zero,
895895
repinit_type_one_side,
896896
repinit_use_three_body,
897-
repformer_update_g1_has_conv,
898897
repformer_direct_dist,
898+
repformer_update_g1_has_conv,
899899
repformer_update_g1_has_drrd,
900900
repformer_update_g1_has_grrg,
901901
repformer_update_g1_has_attn,

0 commit comments

Comments
 (0)