resolve nitpick comments

Author: ChiahsinChu

deepmd/utils/data.py

@@ -502,11 +502,13 @@ def get_single_frame(self, index: int, num_worker: int) -> dict:
         if self.modifier is not None:
             with ThreadPoolExecutor(max_workers=num_worker) as executor:
                 # Apply modifier if it exists
-                executor.submit(
+                future = executor.submit(
                     self.modifier.modify_data,
                     frame_data,
                     self,
                 )
+            # Wait for completion and propagate any exceptions
+            future.result()
             if self.use_modifier_cache:
                 # Cache the modified frame to avoid recomputation
                 self._modified_frame_cache[index] = copy.deepcopy(frame_data)

source/tests/pt/test_data_modifier.py

@@ -62,7 +62,7 @@
 
 
 @modifier_args_plugin.register("random_tester", doc=doc_random_tester)
-def modifier_random_tester() -> list:
+def modifier_random_tester() -> list[Argument]:
     doc_seed = "Random seed used to initialize the random number generator for deterministic scaling factors."
     doc_use_cache = "Whether to cache modified frames to improve performance by avoiding recomputation."
     return [
@@ -72,7 +72,7 @@ def modifier_random_tester() -> list:
 
 
 @modifier_args_plugin.register("zero_tester", doc=doc_zero_tester)
-def modifier_zero_tester() -> list:
+def modifier_zero_tester() -> list[Argument]:
     doc_use_cache = "Whether to cache modified frames to improve performance by avoiding recomputation."
     return [
         Argument("use_cache", bool, optional=True, doc=doc_use_cache),
@@ -377,7 +377,10 @@ def test_inference(self):
         # expected: output_model - sfactor * output_modifier
         for ii in range(3):
             np.testing.assert_allclose(
-                model_pred[ii], model_pred_ref[ii] - sfactor * modifier_pred[ii]
+                model_pred[ii],
+                model_pred_ref[ii] - sfactor * modifier_pred[ii],
+                rtol=1e-5,
+                atol=1e-8,
             )
 
     def tearDown(self) -> None: