Skip to content

Commit eeca009

Browse files
author
Han Wang
committed
fix: Huber energy loss uses raw model energy instead of energy_pred that includes atom_ener_coeff weighting, so coefficients are silently dropped when use_huber=True
1 parent 6c91e99 commit eeca009

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

deepmd/pt/loss/ener.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,8 @@ def forward(
224224
loss += atom_norm * (pref_e * l2_ener_loss)
225225
else:
226226
l_huber_loss = custom_huber_loss(
227-
atom_norm * model_pred["energy"],
228-
atom_norm * label["energy"],
227+
atom_norm * energy_pred,
228+
atom_norm * energy_label,
229229
delta=self.huber_delta,
230230
)
231231
loss += pref_e * l_huber_loss

0 commit comments

Comments
 (0)