Skip to content

Profile bug fix when both enable_profiler and profiling are set to true. #4855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njzjz merged 5 commits into from
Aug 10, 2025
Merged

Profile bug fix when both enable_profiler and profiling are set to true. #4855

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d53e5fa
fix:error when both enable_profiler and profiling are true
OutisLi Jul 31, 2025
03af5fc
fix:docstring for profiling
OutisLi Jul 31, 2025
a6a96e7
doc: specify pytorch backend
OutisLi Aug 1, 2025
2eb1117
Merge branch 'devel' into profile_bugfix
OutisLi Aug 10, 2025
92496f4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deepmd/pt/train/training.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1061,7 +1061,7 @@ def log_loss_valid(_task_key="Default"):
log.info(
f"The profiling trace has been saved under {self.tensorboard_log_dir}"
)
if self.profiling:
if not self.enable_profiler and self.profiling:
prof.export_chrome_trace(self.profiling_file)
log.info(
f"The profiling trace has been saved to: {self.profiling_file}"
Expand Down
2 changes: 1 addition & 1 deletion deepmd/utils/argcheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3137,7 +3137,7 @@ def training_args(
)
doc_disp_training = "Displaying verbose information during training."
doc_time_training = "Timing during training."
doc_profiling = "Export the profiling results to the Chrome JSON file for performance analysis, driven by the legacy TensorFlow profiling API or PyTorch Profiler. The output file will be saved to `profiling_file`."
doc_profiling = "Export the profiling results to the Chrome JSON file for performance analysis, driven by the legacy TensorFlow profiling API or PyTorch Profiler. The output file will be saved to `profiling_file`. When enable_profiler is True, this option is ignored, since the profiling results will be saved to the TensorBoard log."
Comment thread
OutisLi marked this conversation as resolved.
Outdated
doc_profiling_file = "Output file for profiling."
doc_enable_profiler = "Export the profiling results to the TensorBoard log for performance analysis, driven by TensorFlow Profiler (available in TensorFlow 2.3) or PyTorch Profiler. The log will be saved to `tensorboard_log_dir`."
doc_tensorboard = "Enable tensorboard"
Expand Down
Loading