Skip to content

fix: merge get_np_precision to get_xp_precision #4867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njzjz merged 3 commits into from
Aug 5, 2025
Merged

fix: merge get_np_precision to get_xp_precision #4867

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5725b5f
chore: merge get_np_precision to get_xp_precision
njzjz Aug 4, 2025
5e88dcd
add GLOBAL_NP_FLOAT_PRECISION to all
njzjz Aug 5, 2025
d8dfdfc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions deepmd/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
)

__all__ = [
"GLOBAL_NP_FLOAT_PRECISION",
"VALID_ACTIVATION",
"VALID_PRECISION",
"expand_sys_str",
Expand Down Expand Up @@ -245,20 +246,15 @@
numpy precision constant

Raises
------
RuntimeError
if string is invalid
"""
if precision == "default":
return GLOBAL_NP_FLOAT_PRECISION
elif precision == "float16":
return np.float16
elif precision == "float32":
return np.float32
elif precision == "float64":
return np.float64
else:
raise RuntimeError(f"{precision} is not a valid precision")
from deepmd.dpmodel.common import (
get_xp_precision,
)
Comment thread
njzjz marked this conversation as resolved.
Comment on lines +253 to +255

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
deepmd.dpmodel.common
Loading
begins an import cycle.

return get_xp_precision(np, precision)


def symlink_prefix_files(old_prefix: str, new_prefix: str) -> None:
Expand Down