Skip to content

fix: no pinning memory on CPU #4874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njzjz merged 2 commits into from
Aug 8, 2025
Merged

fix: no pinning memory on CPU #4874

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c63bfe9
fix: no pinning memory on CPU
caic99 Aug 7, 2025
29d71aa
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deepmd/pt/train/training.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ def get_dataloader_and_iter(_data, _params):
else 0, # setting to 0 diverges the behavior of its iterator; should be >=1
drop_last=False,
collate_fn=lambda batch: batch, # prevent extra conversion
pin_memory=True,
pin_memory=(DEVICE != "cpu"), # pin memory only if not on CPU
Comment thread
njzjz marked this conversation as resolved.
Outdated
)
_data_iter = cycle_iterator(_dataloader)
return _dataloader, _data_iter
Expand Down
Loading