ci: make Codecov upload non-blocking#5421
Conversation
Allow transient Codecov/OIDC upload failures without turning otherwise passing test jobs red. Authored by OpenClaw (model: gpt-5.4)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo CI workflow files are modified to make Codecov coverage upload steps non-blocking by adding explicit step names and Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5421 +/- ##
==========================================
+ Coverage 80.35% 80.45% +0.10%
==========================================
Files 819 823 +4
Lines 85445 86626 +1181
Branches 4139 4139
==========================================
+ Hits 68661 69699 +1038
- Misses 15508 15651 +143
Partials 1276 1276 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR makes Codecov coverage uploads best-effort in the CI test workflows so transient Codecov/OIDC token timeouts don’t fail otherwise-successful test jobs.
Changes:
- Update
.github/workflows/test_python.ymlto make the Codecov upload step non-blocking viacontinue-on-error: true. - Update
.github/workflows/test_cc.ymlto make the Codecov upload step non-blocking viacontinue-on-error: true.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test_python.yml | Marks the Codecov upload step as non-blocking while keeping OIDC-based upload enabled. |
| .github/workflows/test_cc.yml | Marks the Codecov upload step as non-blocking while keeping OIDC-based upload enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
test_cc.ymltest_python.ymlWhy
A recent CI failure was caused by
codecov/codecov-action@v6failing to fetch an ID token (Failed to get ID Token/Request timeout) after the test steps had already passed. That makes the workflow red for an external upload hiccup rather than for an actual test regression.This change keeps the upload for normal coverage reporting, but treats it as best-effort so flaky third-party upload issues do not block CI.
Validation
git diff --checkAuthored by OpenClaw (model: gpt-5.4)
Summary by CodeRabbit