fix(build): migrate to stable dynamic metadata API#5769
Conversation
Migrate project metadata providers to the scikit-build-core v1 protocol and update the custom provider signature. Require scikit-build-core 1+, opt into v1 behavior, and use the renamed CMake version setting. Fixes: deepmodeling#3558 Coding-Agent: Codex Codex-Version: codex-cli 0.144.1 Model: gpt-5.6-sol Reasoning-Effort: xhigh
📝 WalkthroughWalkthroughThe build backend now uses the standard v1 dynamic metadata provider protocol, returns namespaced metadata fragments, upgrades scikit-build-core configuration, and emits the new CMake version environment variable. ChangesDynamic metadata migration
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pyproject.toml`:
- Around line 227-233: Update both tool.dynamic-metadata entries in the
pyproject configuration to use provider = "backend.dynamic_metadata" and add
provider-path = "."; preserve their existing field values, optional-dependencies
and scripts, respectively.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 3bfbc160-92db-46c3-af43-b5c45dde3613
📒 Files selected for processing (3)
backend/dynamic_metadata.pybackend/read_env.pypyproject.toml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5769 +/- ##
==========================================
- Coverage 79.65% 79.52% -0.13%
==========================================
Files 1015 1015
Lines 115781 115780 -1
Branches 4272 4275 +3
==========================================
- Hits 92229 92079 -150
- Misses 22008 22157 +149
Partials 1544 1544 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary:
[[tool.dynamic-metadata]]interface introduced in scikit-build-core 1.0scikit-build-core>=1, opt intominimum-version = "1.0", and remove the obsolete experimental flagSupersedes #5759, which only widens the upper bound while retaining the deprecated metadata interface.
Fixes #3558
Validation:
ruff check .ruff format .Coding agent: Codex
Codex version: codex-cli 0.144.1
Model: gpt-5.6-sol
Reasoning effort: xhigh
Summary by CodeRabbit