fix(dpmodel): support parameter shorthand in DeepEval#5853
Open
njzjz-bot wants to merge 2 commits into
Open
Conversation
Normalize documented frame and atomic parameter shorthand before automatic batching. Add direct-backend coverage for shared inputs, forced batch splits, and invalid parameter sizes. Coding-Agent: Codex Codex-Version: codex-cli 0.144.4 Model: gpt-5.6-sol Reasoning-Effort: xhigh
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5853 +/- ##
==========================================
- Coverage 78.58% 78.33% -0.25%
==========================================
Files 1050 1050
Lines 120637 120654 +17
Branches 4356 4356
==========================================
- Hits 94801 94515 -286
- Misses 24278 24579 +301
- Partials 1558 1560 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Possible reviewers based on changed lines, exact file history, and exact-file review history:
No review request was made automatically. Coding agent: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5662.
Summary
fparamandaparamshorthand into canonical frame-major arrays before automatic batchingWhy existing tests missed this
Normal public
DeepEval/DeepPotcalls pass through_standard_input, which already tiles shorthand before invoking a backend and therefore masks the dpmodel adapter defect. Existing.dpconsistency coverage uses one frame with full parameter shapes. No regression called the low-level dpmodel backend directly with multiple frames, nor forced automatic batching while passing(natoms, dim_aparam), which the batcher otherwise mistakes for a frame-major array and slices along the atom axis.Validation
pytest source/tests/infer/test_dpmodel_deep_eval_params.py -q(8 passed)DeepEvalcompatibility smoke test with forced one-frame batches (passed)ruff format .(1 new test file reformatted; 1663 files unchanged)ruff check .(passed)git diff --check(passed)Coding agent: Codex
Codex version: codex-cli 0.144.4
Model: gpt-5.6-sol
Reasoning effort: xhigh