Commit b94a27e
fix: relax warmup_ratio lower bound and regenerate schema
Reviewer flagged that `gt=0` rejects the legal `warmup_ratio=0.0` config
(disable warmup). Relax to `ge=0`; `lt=1` is kept because that's the
v5 boundary where warmup_steps flips from ratio to raw step count.
Regenerate the published JSON schema so it reflects the constraint —
otherwise YAML authoring against the schema would pass schema
validation and fail at runtime.
Pushed back on the reviewer's claim that `warmup_steps=0.1` runs zero
warmup: transformers v5 typed `warmup_steps: float` and `get_warmup_steps`
branches on `>= 1`, not `> 0` — `0.1` takes the `math.ceil(N * 0.1)`
fraction branch (training_args.py:2089 in v5.12.1).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>1 parent 14f9576 commit b94a27e
2 files changed
Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1302 | 1302 | | |
1303 | 1303 | | |
1304 | 1304 | | |
| 1305 | + | |
| 1306 | + | |
1305 | 1307 | | |
1306 | 1308 | | |
1307 | 1309 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
0 commit comments