Skip to content

Feat/gcn scorer#261

Merged
SeBorgey merged 28 commits intodevfrom
Feat/gcn_scorer
Aug 27, 2025
Merged

Feat/gcn scorer#261
SeBorgey merged 28 commits intodevfrom
Feat/gcn_scorer

Conversation

@SeBorgey
Copy link
Copy Markdown
Collaborator

Кодстайл пока не делал, нужно утвердить общий смысл

@SeBorgey SeBorgey requested a review from voorhs August 17, 2025 11:56
Comment thread autointent/modules/__init__.py
Comment thread autointent/modules/scoring/_gcn/gcn_scorer.py Outdated
Comment thread autointent/modules/scoring/_gcn/gcn_model.py
Comment thread autointent/modules/scoring/_gcn/gcn_scorer.py Outdated
Comment thread tests/modules/scoring/test_gcn_scorer.py
@SeBorgey SeBorgey requested a review from voorhs August 20, 2025 20:41
Copy link
Copy Markdown
Collaborator

@voorhs voorhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

помимо комментариев к коду есть еще одна вещь: надо добавить GCNScorer в серч спейсы tests/assets/configs/multiclass.yaml и multilabel.yaml

а еще надо подянуть dev и разрешить конфликты, чтобы автотесты запускались

Comment thread autointent/modules/scoring/_gcn/gcn_model.py Outdated
Comment thread autointent/modules/scoring/_torch/base_scorer.py
Comment thread autointent/modules/scoring/_torch/base_scorer.py
Comment thread autointent/modules/scoring/_torch/base_scorer.py
Comment thread autointent/modules/scoring/_gcn/gcn_scorer.py
Comment thread autointent/modules/scoring/_gcn/gcn_scorer.py Outdated
Comment thread autointent/_wrappers/base_torch_module.py
Comment thread autointent/modules/scoring/_gcn/gcn_scorer.py
@SeBorgey SeBorgey requested a review from voorhs August 25, 2025 22:42
Comment thread src/autointent/modules/scoring/_gcn/gcn_scorer.py Outdated
@SeBorgey SeBorgey requested a review from voorhs August 26, 2025 22:57
Comment thread src/autointent/_wrappers/embedder.py Outdated
@SeBorgey SeBorgey merged commit 8562e93 into dev Aug 27, 2025
22 checks passed
@SeBorgey SeBorgey deleted the Feat/gcn_scorer branch August 27, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants