Skip to content

Update README.md: fixed --tp which is invalid is launch option#332

Open
didier-durand wants to merge 1 commit into
deepseek-ai:mainfrom
didier-durand:main
Open

Update README.md: fixed --tp which is invalid is launch option#332
didier-durand wants to merge 1 commit into
deepseek-ai:mainfrom
didier-durand:main

Conversation

@didier-durand

Copy link
Copy Markdown

Hi,
As https://github.com/sgl-project/sglang/blob/main/python/sglang/srt/server_args.py at line 497 and next, --tp is not a valid command option.

Possible values --tensor-parallel-size or --tp-size

I chose --tensor-parallel-size to remain consistent with previous command suggested by this README

Hi,
As  https://github.com/sgl-project/sglang/blob/main/python/sglang/srt/server_args.py at line 497 and next, --tp is not a valid command option.

Possible values --tensor-parallel-size or --tp-size

I chose --tensor-parallel-size to remain consistent with previous command suggested by this README
@didier-durand didier-durand changed the title Update README.md: fixed--tp which is invalid is launch option Update README.md: fixed --tp which is invalid is launch option Feb 8, 2025
@hiSandog

Copy link
Copy Markdown

Confirmed — --tp isn't a valid option for sglang.launch_server; SGLang exposes the short --tp-size and the long --tensor-parallel-size, so the current README command would fail at startup. Using --tensor-parallel-size here also matches the vllm serve ... --tensor-parallel-size 2 line just above, which is a nice consistency win.

One thing worth double-checking before merge: that --tensor-parallel-size is indeed the spelling the SGLang version the README targets accepts (the flag surface has shifted between SGLang releases). If there's any doubt, --tp-size is the safer canonical short form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants