Skip to content

fix: buckets attribute#252

Merged
ArzelaAscoIi merged 4 commits into
mainfrom
fix/bucketsAttribute
Apr 22, 2025
Merged

fix: buckets attribute#252
ArzelaAscoIi merged 4 commits into
mainfrom
fix/bucketsAttribute

Conversation

@ArzelaAscoIi
Copy link
Copy Markdown
Member

@ArzelaAscoIi ArzelaAscoIi commented Apr 22, 2025

Related Issues

  • old versions of pyrate limiter breaking disposing buckets (see comments in code)

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

@ArzelaAscoIi ArzelaAscoIi requested review from a team and wochinge April 22, 2025 08:24
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  deepset_cloud_sdk/_s3
  upload.py 119-120
Project Total  

This report was generated by python-coverage-comment-action

@ArzelaAscoIi ArzelaAscoIi enabled auto-merge April 22, 2025 08:31
@ArzelaAscoIi ArzelaAscoIi disabled auto-merge April 22, 2025 08:32
Comment thread deepset_cloud_sdk/_s3/upload.py
Comment thread deepset_cloud_sdk/_s3/upload.py Outdated
Co-authored-by: Abraham Yusuf <abrahamy@users.noreply.github.com>
@ArzelaAscoIi ArzelaAscoIi enabled auto-merge April 22, 2025 09:15
@ArzelaAscoIi ArzelaAscoIi requested a review from abrahamy April 22, 2025 09:15
@ArzelaAscoIi ArzelaAscoIi added this pull request to the merge queue Apr 22, 2025
Merged via the queue into main with commit c667895 Apr 22, 2025
9 checks passed
@ArzelaAscoIi ArzelaAscoIi deleted the fix/bucketsAttribute branch April 22, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants