feat: enable publishing pipelines and indexes to deepset AI platfrom#256
Merged
Conversation
added 4 commits
May 22, 2025 10:56
faymarie
commented
May 22, 2025
faymarie
commented
May 22, 2025
added 4 commits
May 22, 2025 11:25
Member
ArzelaAscoIi
left a comment
There was a problem hiding this comment.
looking good already! Some comments about the DX. Looking forward to have this feature!
(Iiiiiif you could add an integration tests that actually pushes a pipeline to the cloud, would be amazing btw.)
wochinge
reviewed
May 22, 2025
Contributor
wochinge
left a comment
There was a problem hiding this comment.
Left more general comments as of now.
In general very good first throw! I especially like the naming (publish, workflows) and it's already fairly intuitive!
Co-authored-by: Tobias Wochinger <tobias.wochinger@deepset.ai>
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
wochinge
reviewed
May 27, 2025
Contributor
wochinge
left a comment
There was a problem hiding this comment.
A few smaller questions but looks good to me already.
What are the next steps? Secrets & OpenSearch?
agnieszka-m
reviewed
May 27, 2025
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
agnieszka-m
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes?
Allows adding Haystack Pipeline and AsyncPipeline as Pipeline or Index to deepset AI platform as a ymal string.
Adds inputs and outputs.
Secrets, AnswerBuilder, DocumentStores, return values etc will be managed in separate PRs!
How did you test it?
Notes for the reviewer
Screenshots (optional)
Checklist