fix: missing sniffio dependency#287
Merged
Merged
Conversation
…8+pydantic combination
abrahamy
commented
Dec 1, 2025
abrahamy
commented
Dec 1, 2025
abrahamy
commented
Dec 1, 2025
abrahamy
commented
Dec 1, 2025
abrahamy
commented
Dec 1, 2025
abrahamy
commented
Dec 1, 2025
abrahamy
commented
Dec 1, 2025
abrahamy
commented
Dec 1, 2025
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
anakin87
reviewed
Dec 1, 2025
| "haystack-ai>=2.13.2", # only for testing | ||
| "haystack-ai>=2.13.2", # only for testing | ||
| "respx==0.22.0", | ||
| "sniffio>=1.3.1", |
Member
There was a problem hiding this comment.
Just taking a look... sorry if my question is dumb.
Why not adding sniffio to dependencies instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
sniffiodependency #286Proposed Changes?
The project had
requires-python = >= 3.8but thepydanticlibrary had a transitive dependency a version ofsniffiothat is not compatible with Python 3.8. Hatch could not resolve the dependencies due to this.I also took the opportunity to migrate the project to
uvas we have already done so in other projects.How did you test it?
Notes for the reviewer
Screenshots (optional)
Checklist