fix: move sniffio from test to runtime dependencies#298
Merged
Conversation
sniffio is imported in production code (deepset_cloud_sdk/workflows/async_client/files.py) to catch AsyncLibraryNotFoundError, but was only listed as a test dependency. This broke at runtime when anyio 4.0+ dropped sniffio as a transitive dependency. Resolves BUIG-13 Co-authored-by: Cursor <cursoragent@cursor.com>
Coverage report
This PR does not seem to contain any modification to coverable code. |
|
looks good to me - do you also look into pyrate-limiter? |
Member
Author
deep-rloebbert
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sniffio>=1.3.1from[dependency-groups] testto[project] dependenciesinpyproject.tomlsniffiois imported in production code (deepset_cloud_sdk/workflows/async_client/files.py) to catchAsyncLibraryNotFoundError, making it a runtime requirementanyio4.0+ droppedsniffioas a transitive dependency, so it's no longer pulled in viahttpx->anyioTest plan
uv run python -c "from deepset_cloud_sdk.workflows.async_client.files import list_files"succeedssniffioappears as a runtime dep inuv.lockResolves BUIG-13