feat: add skip_validation_errors parameter to create_pipeline and update_pipeline (#90)

* feat: add skip_validation_errors parameter to create_pipeline

* feat: add skip_validation_errors parameter to update_pipeline

* feat: add skip_validation_errors parameter to create_pipeline MCP tool

* feat: add skip_validation_errors parameter to update_pipeline MCP tool

* test: update create_pipeline test to use skip_validation_errors=False

* test: update update_pipeline test to use skip_validation_errors=False

* test: add tests for skip_validation_errors functionality

* test: add tests for skip_validation_errors parameter in create_pipeline

* test: add tests for skip_validation_errors parameter in update_pipeline

* fix: linting, remove validation param from mcp

* fix: format

Author: mathislucka

src/deepset_mcp/main.py

@@ -121,7 +121,12 @@ async def get_pipeline(pipeline_name: str) -> str:
 
 @mcp.tool()
 async def create_pipeline(pipeline_name: str, yaml_configuration: str) -> str:
-    """Creates a new pipeline in deepset."""
+    """Creates a new pipeline in deepset.
+
+    Args:
+        pipeline_name: Name of the pipeline to create
+        yaml_configuration: YAML configuration for the pipeline
+    """
     workspace = get_workspace()
     async with AsyncDeepsetClient() as client:
         response = await create_pipeline_tool(client, workspace, pipeline_name, yaml_configuration)
@@ -138,6 +143,11 @@ async def update_pipeline(
     The update is performed by replacing the original configuration snippet with the new one.
     Make sure that your original snippet only has a single exact match in the pipeline configuration.
     Respect whitespace and formatting.
+
+    Args:
+        pipeline_name: Name of the pipeline to update
+        original_configuration_snippet: The configuration snippet to replace
+        replacement_configuration_snippet: The new configuration snippet
     """
     workspace = get_workspace()
     async with AsyncDeepsetClient() as client:

src/deepset_mcp/tools/pipeline.py

@@ -36,12 +36,25 @@ async def validate_pipeline(client: AsyncClientProtocol, workspace: str, yaml_co
 
 
 async def create_pipeline(
-    client: AsyncClientProtocol, workspace: str, pipeline_name: str, yaml_configuration: str
+    client: AsyncClientProtocol,
+    workspace: str,
+    pipeline_name: str,
+    yaml_configuration: str,
+    skip_validation_errors: bool = True,
 ) -> str:
-    """Creates a new pipeline within the currently configured deepset workspace."""
+    """Creates a new pipeline within the currently configured deepset workspace.
+
+    Args:
+        client: The async client for API communication
+        workspace: The workspace name
+        pipeline_name: Name of the pipeline to create
+        yaml_configuration: YAML configuration for the pipeline
+        skip_validation_errors: If True (default), creates the pipeline even if validation fails.
+                               If False, stops creation when validation fails.
+    """
     validation_response = await client.pipelines(workspace=workspace).validate(yaml_configuration)
 
-    if not validation_response.valid:
+    if not validation_response.valid and not skip_validation_errors:
         return validation_result_to_llm_readable_string(validation_response)
 
     try:
@@ -53,7 +66,14 @@ async def create_pipeline(
     except UnexpectedAPIError as e:
         return f"Failed to create pipeline '{pipeline_name}': {e}"
 
-    return f"Pipeline '{pipeline_name}' created successfully."
+    success_message = f"Pipeline '{pipeline_name}' created successfully."
+
+    # If validation failed, but we created anyway, include validation errors
+    if not validation_response.valid:
+        validation_errors = validation_result_to_llm_readable_string(validation_response)
+        return f"{success_message}\n\n**Note: Pipeline was created despite validation issues:**\n{validation_errors}"
+
+    return success_message
 
 
 async def update_pipeline(
@@ -62,13 +82,23 @@ async def update_pipeline(
     pipeline_name: str,
     original_config_snippet: str,
     replacement_config_snippet: str,
+    skip_validation_errors: bool = True,
 ) -> str:
     """
     Updates a pipeline configuration in the specified workspace with a replacement configuration snippet.
 
     This function validates the replacement configuration snippet before applying it to the pipeline.
-    If the validation fails, it returns a readable string describing validation errors. Otherwise, the
-    replacement snippet is used to update the pipeline's configuration in the target workspace.
+    If the validation fails and skip_validation_errors is False, it returns a readable string describing
+    validation errors. Otherwise, the replacement snippet is used to update the pipeline's configuration.
+
+    Args:
+        client: The async client for API communication
+        workspace: The workspace name
+        pipeline_name: Name of the pipeline to update
+        original_config_snippet: The configuration snippet to replace
+        replacement_config_snippet: The new configuration snippet
+        skip_validation_errors: If True (default), updates the pipeline even if validation fails.
+                               If False, stops update when validation fails.
     """
     try:
         original_pipeline = await client.pipelines(workspace=workspace).get(pipeline_name=pipeline_name)
@@ -95,7 +125,7 @@ async def update_pipeline(
 
     validation_response = await client.pipelines(workspace=workspace).validate(updated_yaml_configuration)
 
-    if not validation_response.valid:
+    if not validation_response.valid and not skip_validation_errors:
         return validation_result_to_llm_readable_string(validation_response)
 
     try:
@@ -109,7 +139,14 @@ async def update_pipeline(
     except UnexpectedAPIError as e:
         return f"Failed to update the pipeline '{pipeline_name}': {e}"
 
-    return f"The pipeline '{pipeline_name}' was successfully updated."
+    success_message = f"The pipeline '{pipeline_name}' was successfully updated."
+
+    # If validation failed, but we updated anyway, include validation errors
+    if not validation_response.valid:
+        validation_errors = validation_result_to_llm_readable_string(validation_response)
+        return f"{success_message}\n\n**Note: Pipeline was updated despite validation issues:**\n{validation_errors}"
+
+    return success_message
 
 
 async def get_pipeline_logs(

test/unit/tools/test_pipeline.py

@@ -223,7 +223,9 @@ async def test_create_pipeline_handles_validation_failure() -> None:
     invalid_result = PipelineValidationResult(valid=False, errors=[ValidationError(code="E", message="Err")])
     resource = FakePipelineResource(validate_response=invalid_result)
     client = FakeClient(resource)
-    result = await create_pipeline(client, workspace="ws", pipeline_name="pname", yaml_configuration="cfg")
+    result = await create_pipeline(
+        client, workspace="ws", pipeline_name="pname", yaml_configuration="cfg", skip_validation_errors=False
+    )
     assert "invalid" in result.lower()
     assert "Error 1" in result
 
@@ -251,6 +253,42 @@ async def test_create_pipeline_handles_success_and_failure_response() -> None:
     assert "Failed to create pipeline 'p1': bad things (Status Code: 400)" == res_fail
 
 
+@pytest.mark.asyncio
+async def test_create_pipeline_skip_validation_errors_true() -> None:
+    """Test that create_pipeline creates the pipeline despite validation errors."""
+    invalid_result = PipelineValidationResult(
+        valid=False, errors=[ValidationError(code="E1", message="Test error message")]
+    )
+    resource = FakePipelineResource(
+        validate_response=invalid_result,
+        create_response=NoContentResponse(message="created successfully"),
+    )
+    client = FakeClient(resource)
+
+    # Test with explicit True
+    result = await create_pipeline(
+        client,
+        workspace="ws",
+        pipeline_name="test_pipeline",
+        yaml_configuration="config: test",
+        skip_validation_errors=True,
+    )
+
+    assert "Pipeline 'test_pipeline' created successfully." in result
+    assert "Note: Pipeline was created despite validation issues:" in result
+    assert "configuration is invalid" in result
+    assert "Error 1" in result
+    assert "Test error message" in result
+
+    # Test with default (should behave the same as True)
+    result_default = await create_pipeline(
+        client, workspace="ws", pipeline_name="test_pipeline", yaml_configuration="config: test"
+    )
+
+    assert "Pipeline 'test_pipeline' created successfully." in result_default
+    assert "Note: Pipeline was created despite validation issues:" in result_default
+
+
 @pytest.mark.asyncio
 async def test_update_pipeline_not_found_on_get() -> None:
     resource = FakePipelineResource(get_exception=ResourceNotFoundError())
@@ -330,6 +368,7 @@ async def test_update_pipeline_validation_failure() -> None:
         pipeline_name="np",
         original_config_snippet="foo: 1",
         replacement_config_snippet="foo: 2",
+        skip_validation_errors=False,
     )
     assert "invalid" in res.lower()
     assert "Error 1" in res
@@ -430,6 +469,62 @@ async def test_update_pipeline_success_response() -> None:
     assert "successfully updated" in r_success.lower()
 
 
+@pytest.mark.asyncio
+async def test_update_pipeline_skip_validation_errors_true() -> None:
+    """Test that update_pipeline updates the pipeline despite validation errors."""
+    user = DeepsetUser(user_id="u1", given_name="A", family_name="B")
+    orig_yaml = "foo: 1"
+    original = DeepsetPipeline(
+        pipeline_id="p",
+        name="np",
+        status="S",
+        service_level=PipelineServiceLevel.DEVELOPMENT,
+        created_at=datetime.now(),
+        last_edited_at=None,
+        created_by=user,
+        last_edited_by=None,
+        yaml_config=orig_yaml,
+    )
+    invalid_result = PipelineValidationResult(
+        valid=False, errors=[ValidationError(code="E1", message="Test error message")]
+    )
+
+    resource = FakePipelineResource(
+        get_response=original,
+        validate_response=invalid_result,
+        update_response=NoContentResponse(message="successfully updated"),
+    )
+    client = FakeClient(resource)
+
+    # Test with explicit True
+    result = await update_pipeline(
+        client,
+        workspace="ws",
+        pipeline_name="np",
+        original_config_snippet="foo: 1",
+        replacement_config_snippet="foo: 2",
+        skip_validation_errors=True,
+    )
+
+    assert "The pipeline 'np' was successfully updated." in result
+    assert "Note: Pipeline was updated despite validation issues:" in result
+    assert "configuration is invalid" in result
+    assert "Error 1" in result
+    assert "Test error message" in result
+
+    # Test with default (should behave the same as True)
+    result_default = await update_pipeline(
+        client,
+        workspace="ws",
+        pipeline_name="np",
+        original_config_snippet="foo: 1",
+        replacement_config_snippet="foo: 2",
+    )
+
+    assert "The pipeline 'np' was successfully updated." in result_default
+    assert "Note: Pipeline was updated despite validation issues:" in result_default
+
+
 @pytest.mark.asyncio
 async def test_get_pipeline_logs_success() -> None:
     log1 = PipelineLog(