fix: create_pipeline tool kwarg mismatch (BUI-670)#207
Merged
Conversation
The create_pipeline tool called PipelineResource.create(name=...) but the implementation expects pipeline_name=..., causing the tool to fail with "got an unexpected keyword argument 'name'". The protocol declared the parameter as `name` while the implementation used `pipeline_name`, so tests against mocks passed but real calls failed. Aligned the protocol, mocks, and caller on `pipeline_name` to match the implementation and the rest of the pipeline resource API. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
tstadel
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_pipelinefailed withPipelineResource.create() got an unexpected keyword argument 'name'.name, butPipelineResource.createis defined withpipeline_name. Mocks followed the protocol, so unit tests passed while the real call failed.pipeline_nameto match the implementation and the rest of the pipeline resource API.Test plan
uv run pytest test/unit/tools/test_pipeline.py test/unit/api/pipeline/test_pipeline_resource.py test/unit/tools/test_doc_search.pypassesuv run mypyclean on changed filescreate_pipelinevia deepset-mcp against a real workspace🤖 Generated with Claude Code