chore: add query filter to search history tool#208
Merged
Conversation
ArzelaAscoIi
approved these changes
May 5, 2026
|
|
||
| async def list(self, limit: int = 10, after: str | None = None) -> PaginatedResponse[SearchHistoryEntry]: | ||
| async def list( | ||
| self, limit: int = 10, after: str | None = None, query_filter: str | None = None |
Member
There was a problem hiding this comment.
FIY: we saw in the pipeline team that telling the model how to use a tool can be a bit challenging somethings. I guess you already added it to the prompt how to list etc, i guess 🤔 (otherwise it will probably retry until it works)
Contributor
Author
There was a problem hiding this comment.
@ArzelaAscoIi I added The tool accepts query_filter as a param, so the time range and any other filter can be passed there. only, should i explain more how to actually provide it ?
Member
There was a problem hiding this comment.
no all good. i think it works 👍 Depending on the quality and speed etc, adding some examples etc to the agent for this filter might speed things up. But these are just iterations
tholor
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.