Skip to content

add agents example with GitHub components & tools from new integration#183

Merged
bilgeyucel merged 9 commits intomainfrom
agents-example-experimental
Jun 30, 2025
Merged

add agents example with GitHub components & tools from new integration#183
bilgeyucel merged 9 commits intomainfrom
agents-example-experimental

Conversation

@julian-risch
Copy link
Copy Markdown
Member

@julian-risch julian-risch commented Apr 10, 2025

This new notebook goes beyond what the GitHub Issue Resolver notebook shows. It additionally forks the repository, edits files in multiple commits and simulates opening a pull request. Here is an example:
deepset-ai/haystack-core-integrations@main...haystack-demo-user:haystack-core-integrations:fix-1268

When users run the tutorial, they will actually fork the repo and in their fork they will actually create some commits, which is nice. They won't automatically open an actual PR, which is nice too. :D

For context: @sjrl brought up that one way to keep example files from the experimental Agent around is an integration deepset-ai/haystack-experimental#263 (comment)

deepset-ai/haystack-core-integrations#1637

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@julian-risch julian-risch marked this pull request as ready for review June 12, 2025 15:16
@julian-risch julian-risch changed the title add agents example with GitHub components from experimental add agents example with GitHub components & tools from new integration Jun 12, 2025
@@ -0,0 +1,930 @@
{
Copy link
Copy Markdown
Contributor

@bilgeyucel bilgeyucel Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a description before this, explaning what we're doing. Somethinglike:

GitHub Issue Resolver

First, we'll create a GitHub issue resolver agent, following the steps in this recipe: Build a GitHub Issue Resolver Agent(https://haystack.deepset.ai/cookbook/github_issue_resolver_agent)


Reply via ReviewNB

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@@ -0,0 +1,930 @@
{
Copy link
Copy Markdown
Contributor

@bilgeyucel bilgeyucel Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the website, this markdown output is rendered as part of the recipe. We need to either copy and put it as a text or remove it completely


Reply via ReviewNB

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a new cell with text

@@ -0,0 +1,930 @@
{
Copy link
Copy Markdown
Contributor

@bilgeyucel bilgeyucel Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do I pass a title here?


Reply via ReviewNB

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be needed. GitHubPRCreator requires a title but the Agent should be able to generate it as a tool input.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it now.

@@ -0,0 +1,930 @@
{
Copy link
Copy Markdown
Contributor

@bilgeyucel bilgeyucel Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here with the markdown content


Reply via ReviewNB

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a new cell with text

Copy link
Copy Markdown
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left my comments on review nb

@julian-risch julian-risch requested a review from bilgeyucel June 25, 2025 08:52
@bilgeyucel bilgeyucel merged commit 7c45ddb into main Jun 30, 2025
1 check passed
@bilgeyucel bilgeyucel deleted the agents-example-experimental branch June 30, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Agent from experimental to main

2 participants