Add example notebook for itinerary planning using OpenStreetMap-integration,and Haystack Agent#258
Add example notebook for itinerary planning using OpenStreetMap-integration,and Haystack Agent#258grexrr wants to merge 4 commits intodeepset-ai:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,1237 @@ | |||
| { | |||
There was a problem hiding this comment.
Could we rename this notebook to something like "Agentic itinerary planning using OpenStreetMap"? I feel we should focus on the goal of this notebook.
Reply via ReviewNB
| @@ -0,0 +1,1237 @@ | |||
| { | |||
There was a problem hiding this comment.
I would remove the "OpenStreetMap + Haystack: From basic queries to agents" header, as there is already a notebook title above.
Would you like to put author attribution here?
Reply via ReviewNB
| @@ -0,0 +1,1237 @@ | |||
| { | |||
There was a problem hiding this comment.
I feel the section title might be confusing for the readers. Vectorization is quite common in RAG-like pipelines, and people tend to think about vector embeddings. Can we rename it?
Reply via ReviewNB
| @@ -0,0 +1,1237 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #4. if "OPENAI_API_KEY" in os.environ:
Could you please remove that part? I makes automated testing impossible, if we delete the env variable.
Reply via ReviewNB
| @@ -0,0 +1,1237 @@ | |||
| { | |||
There was a problem hiding this comment.
Could we install that dependency at the very beginning of the notebook? That's what we typically do.
Reply via ReviewNB
| @@ -0,0 +1,1237 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1237 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1237 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1237 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #20. itinerary_prompt_builder = ChatPromptBuilder(template=itinerary_prompt_template)
Could you please add required_variables=["documents", "user_request"] to avoid having a warning?
Reply via ReviewNB
| @@ -0,0 +1,1237 @@ | |||
| { | |||
There was a problem hiding this comment.
|
Thanks for contributing this example, @grexrr. Let me apologize it took so long, but we're catching up with the community contributions. I really liked the idea, but left some minor comments! |
2 participants
This PR adds a tutorial notebook demonstrating how to use the
OSMFetcherfromosm-integration-haystackwith Haystack's Agent framework.The notebook includes:
PipelineToolwrappingOSMFetcher + ChatPromptBuilderto reduce token usageThe agent is guided via a system prompt and handles tool invocation autonomously.
This notebook was added following reviewer feedback on my OpenStreetMap integration PR, to illustrate how the component can be used in an Agent-based application.