refactor: replace OutputAdapter in using_hyde_for_improved_retrieval notebook#279
Open
manishpanda01 wants to merge 1 commit intodeepset-ai:mainfrom
Open
refactor: replace OutputAdapter in using_hyde_for_improved_retrieval notebook#279manishpanda01 wants to merge 1 commit intodeepset-ai:mainfrom
manishpanda01 wants to merge 1 commit intodeepset-ai:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
bilgeyucel
reviewed
Apr 16, 2026
Contributor
bilgeyucel
left a comment
bilgeyucel
left a comment
There was a problem hiding this comment.
Hi @manishpanda01, can you give me more info on the component? I see that it does exactly the same thing as OutputAdapter. The idea behind OutputAdapter is to avoid creating custom components for small tweaks to component I/O and to handle these tweaks easily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR replaces
OutputAdapterin theusing_hyde_for_improved_retrievalnotebook with a small custom component that converts generator replies into
Documentobjects.How did you test it?
I ran the updated notebook cells locally and verified that the pipeline still
executes and produces document inputs for the embedder.
Notes for the reviewer
I focused on one notebook first to avoid changing cases where these components
may still affect retrieval behavior rather than just pipeline wiring.