Skip to content

Commit 006021e

Browse files
jliounisPSI Bot
authored andcommitted
Address review comments: remove auto-gen CHANGELOG, keyword-only init, assert api_key serialization
1 parent 92a1749 commit 006021e

4 files changed

Lines changed: 15 additions & 12 deletions

File tree

integrations/perplexity/CHANGELOG.md

Lines changed: 0 additions & 9 deletions
This file was deleted.

integrations/perplexity/src/haystack_integrations/components/websearch/perplexity/__init__.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
#
33
# SPDX-License-Identifier: Apache-2.0
44

5-
from haystack_integrations.components.websearch.perplexity.perplexity_websearch import PerplexityWebSearch
5+
from haystack_integrations.components.websearch.perplexity.perplexity_websearch import (
6+
PerplexityWebSearch,
7+
)
68

79
__all__ = ["PerplexityWebSearch"]

integrations/perplexity/src/haystack_integrations/components/websearch/perplexity/perplexity_websearch.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ class PerplexityWebSearch:
5252

5353
def __init__(
5454
self,
55+
*,
5556
api_key: Secret = Secret.from_env_var("PERPLEXITY_API_KEY"),
5657
top_k: int | None = 10,
5758
search_params: dict[str, Any] | None = None,

integrations/perplexity/tests/test_perplexity_websearch.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ def test_to_dict(self, monkeypatch):
7272
data = component_to_dict(ws, "PerplexityWebSearch")
7373
expected_type = "haystack_integrations.components.websearch.perplexity.perplexity_websearch.PerplexityWebSearch"
7474
assert data["type"] == expected_type
75+
assert data["init_parameters"]["api_key"] == Secret.from_env_var("PERPLEXITY_API_KEY").to_dict()
7576
assert data["init_parameters"]["top_k"] == 5
7677
assert data["init_parameters"]["search_params"] == {"country": "US"}
7778

@@ -83,7 +84,11 @@ def test_from_dict(self, monkeypatch):
8384
"top_k": 3,
8485
"search_params": {"search_recency_filter": "day"},
8586
"timeout": 15.0,
86-
"api_key": {"env_vars": ["PERPLEXITY_API_KEY"], "strict": True, "type": "env_var"},
87+
"api_key": {
88+
"env_vars": ["PERPLEXITY_API_KEY"],
89+
"strict": True,
90+
"type": "env_var",
91+
},
8792
},
8893
}
8994
ws = component_from_dict(PerplexityWebSearch, data, "PerplexityWebSearch")
@@ -153,7 +158,11 @@ def test_run_uses_init_search_params_when_no_runtime_override(self):
153158
ws.run(query="hello")
154159

155160
body = json.loads(captured[0].content)
156-
assert body == {"query": "hello", "search_recency_filter": "week", "max_results": 5}
161+
assert body == {
162+
"query": "hello",
163+
"search_recency_filter": "week",
164+
"max_results": 5,
165+
}
157166

158167
@pytest.mark.asyncio
159168
async def test_run_async(self):

0 commit comments

Comments
 (0)