Simplified _get_unique_index_name ; Removed some redundant comments

Author: mpangrazzi

integrations/opensearch/tests/conftest.py

@@ -1,25 +1,19 @@
 import asyncio
-import re
+import uuid
 
 import pytest
 from haystack import Document
 
 from haystack_integrations.document_stores.opensearch.document_store import OpenSearchDocumentStore
 
 
-def _get_unique_index_name(request) -> str:
+def _get_unique_index_name() -> str:
     """
-    Generate a unique, valid OpenSearch index name from the test's nodeid.
+    Generate a unique, valid OpenSearch index name for test isolation.
 
-    Uses the full nodeid (e.g., 'test_document_store_async.py::TestClass::test_method')
-    to avoid collisions when tests in different files/classes share the same method name.
+    Each test gets its own index to enable parallel test execution without conflicts.
     """
-    # Use nodeid for uniqueness across files/classes, sanitize for valid index name
-    # OpenSearch index names must be lowercase and cannot contain: \, /, *, ?, ", <, >, |, space, comma, #
-    index_name = re.sub(r"[^a-zA-Z0-9_-]", "_", request.node.nodeid).lower()
-    # Ensure it doesn't start with -, _, or + and is not longer than 255 chars
-    index_name = index_name.lstrip("-_+")[:255]
-    return index_name
+    return f"test_{uuid.uuid4().hex}"
 
 
 @pytest.fixture
@@ -29,8 +23,7 @@ def document_store(request):
     `return_embedding` is set to True because in filters tests we compare embeddings.
     """
     hosts = ["https://localhost:9200"]
-    # Use a different index for each test so we can run them in parallel
-    index = _get_unique_index_name(request)
+    index = _get_unique_index_name()
 
     store = OpenSearchDocumentStore(
         hosts=hosts,
@@ -54,7 +47,7 @@ def document_store(request):
 @pytest.fixture
 def document_store_2(request):
     hosts = ["https://localhost:9200"]
-    index = f"test_index_2_{_get_unique_index_name(request)}"
+    index = f"test_index_2_{_get_unique_index_name()}"
 
     store = OpenSearchDocumentStore(
         hosts=hosts,
@@ -83,7 +76,7 @@ def document_store_readonly(request):
     """
     hosts = ["https://localhost:9200"]
     # Use a different index for each test so we can run them in parallel
-    index = _get_unique_index_name(request)
+    index = _get_unique_index_name()
 
     store = OpenSearchDocumentStore(
         hosts=hosts,
@@ -111,8 +104,7 @@ def document_store_embedding_dim_4_no_emb_returned(request):
     A document store with embedding dimension 4 that does not return embeddings.
     """
     hosts = ["https://localhost:9200"]
-    # Use a different index for each test so we can run them in parallel
-    index = _get_unique_index_name(request)
+    index = _get_unique_index_name()
 
     store = OpenSearchDocumentStore(
         hosts=hosts,
@@ -136,8 +128,7 @@ def document_store_embedding_dim_4_no_emb_returned_faiss(request):
     https://opensearch.org/docs/latest/vector-search/filter-search-knn/efficient-knn-filtering/.
     """
     hosts = ["https://localhost:9200"]
-    # Use a different index for each test so we can run them in parallel
-    index = _get_unique_index_name(request)
+    index = _get_unique_index_name()
 
     store = OpenSearchDocumentStore(
         hosts=hosts,