adding Mixin tests + overriding and fixing to pass tests

Author: davidsbatista

integrations/valkey/src/haystack_integrations/document_stores/valkey/document_store.py

@@ -1544,7 +1544,7 @@ def _validate_and_normalize_metadata_fields(metadata_fields: dict[str, type[str]
             msg = "metadata_fields must be a dictionary"
             raise ValueError(msg)
 
-        type_mapping = {str: "tag", int: "numeric"}
+        type_mapping = {str: "tag", int: "numeric", float: "numeric"}
 
         normalized = {}
         for field_name, field_type in metadata_fields.items():

integrations/valkey/tests/test_document_store.py

@@ -14,19 +14,19 @@
 from haystack.dataclasses.byte_stream import ByteStream
 from haystack.document_stores.types import DuplicatePolicy
 from haystack.testing.document_store import (
+    CountDocumentsByFilterTest,
     CountDocumentsTest,
+    CountUniqueMetadataByFilterTest,
     DeleteAllTest,
     DeleteByFilterTest,
     DeleteDocumentsTest,
     FilterableDocsFixtureMixin,
+    GetMetadataFieldMinMaxTest,
+    GetMetadataFieldsInfoTest,
+    GetMetadataFieldUniqueValuesTest,
     UpdateByFilterTest,
     WriteDocumentsTest,
     create_filterable_docs,
-    CountDocumentsByFilterTest,
-    CountUniqueMetadataByFilterTest,
-    GetMetadataFieldsInfoTest,
-    GetMetadataFieldMinMaxTest,
-    GetMetadataFieldUniqueValuesTest,
 )
 from haystack.utils import Secret
 
@@ -74,6 +74,8 @@ def document_store(self):
                 "quality": str,
                 "year": int,
                 "featured": int,  # for base-class test_update_by_filter_advanced_filters (meta.featured)
+                "rating": float,  # for GetMetadataFieldMinMaxTest (float field)
+                "age": int,  # for GetMetadataFieldMinMaxTest meta_prefix test
                 # for base-class UpdateByFilterTest.filterable_docs and filter tests:
                 "name": str,
                 "page": str,
@@ -104,6 +106,10 @@ def test_write_documents(self, document_store):
         assert document_store.write_documents(docs) == 1
         assert document_store.count_documents() == 1
 
+    def test_get_metadata_fields_info_empty_collection(self, document_store):
+        """Valkey pre-configures metadata fields at init, so they're always present even when empty."""
+        pytest.skip("Valkey metadata fields are pre-configured at init, not discovered from documents")
+
     def test_write_documents_duplicate_fail(self, document_store):
         """Valkey only supports OVERWRITE policy, skip FAIL test."""
         pytest.skip("Valkey only supports DuplicatePolicy.OVERWRITE")