fix: Change default alpha value to float

Author: maxdswain

integrations/weaviate/src/haystack_integrations/components/retrievers/weaviate/hybrid_retriever.py

@@ -9,7 +9,6 @@
 from haystack.document_stores.types.filter_policy import apply_filter_policy
 
 from haystack_integrations.document_stores.weaviate import WeaviateDocumentStore
-from haystack_integrations.document_stores.weaviate.document_store import DEFAULT_ALPHA
 
 
 @component
@@ -24,7 +23,7 @@ def __init__(
         document_store: WeaviateDocumentStore,
         filters: dict[str, Any] | None = None,
         top_k: int = 10,
-        alpha: float = DEFAULT_ALPHA,
+        alpha: float = 0.7,
         max_vector_distance: float | None = None,
         filter_policy: str | FilterPolicy = FilterPolicy.REPLACE,
     ):

integrations/weaviate/src/haystack_integrations/document_stores/weaviate/document_store.py

@@ -66,9 +66,6 @@
 # See WeaviateDocumentStore._query_with_filters() for more information.
 DEFAULT_QUERY_LIMIT = 9999
 
-# See weaviate.collections.queries.hybrid.query.sync.pyi for the default value of alpha
-DEFAULT_ALPHA = 0.7
-
 
 class WeaviateDocumentStore:
     """
@@ -1572,7 +1569,7 @@ def _hybrid_retrieval(
         query_embedding: list[float],
         filters: dict[str, Any] | None = None,
         top_k: int | None = None,
-        alpha: float = DEFAULT_ALPHA,
+        alpha: float = 0.7,
         max_vector_distance: float | None = None,
     ) -> list[Document]:
         properties = [p.name for p in self.collection.config.get().properties]
@@ -1597,7 +1594,7 @@ async def _hybrid_retrieval_async(
         query_embedding: list[float],
         filters: dict[str, Any] | None = None,
         top_k: int | None = None,
-        alpha: float = DEFAULT_ALPHA,
+        alpha: float = 0.7,
         max_vector_distance: float | None = None,
     ) -> list[Document]:
         collection = await self.async_collection

integrations/weaviate/tests/test_hybrid_retriever.py

@@ -9,7 +9,6 @@
 
 from haystack_integrations.components.retrievers.weaviate import WeaviateHybridRetriever
 from haystack_integrations.document_stores.weaviate import WeaviateDocumentStore
-from haystack_integrations.document_stores.weaviate.document_store import DEFAULT_ALPHA
 
 
 def test_init_default():
@@ -18,7 +17,7 @@ def test_init_default():
     assert retriever._document_store == mock_document_store
     assert retriever._filters == {}
     assert retriever._top_k == 10
-    assert retriever._alpha == DEFAULT_ALPHA
+    assert retriever._alpha == 0.7
     assert retriever._max_vector_distance is None
     assert retriever._filter_policy == FilterPolicy.REPLACE
 
@@ -57,7 +56,7 @@ def test_to_dict(_mock_weaviate):
         "init_parameters": {
             "filters": {},
             "top_k": 10,
-            "alpha": DEFAULT_ALPHA,
+            "alpha": 0.7,
             "max_vector_distance": None,
             "filter_policy": "replace",
             "document_store": {
@@ -113,7 +112,7 @@ def test_from_dict(_mock_weaviate):
             "init_parameters": {
                 "filters": {},
                 "top_k": 10,
-                "alpha": DEFAULT_ALPHA,
+                "alpha": 0.7,
                 "max_vector_distance": None,
                 "filter_policy": "replace",
                 "document_store": {
@@ -143,7 +142,7 @@ def test_from_dict(_mock_weaviate):
     assert retriever._document_store
     assert retriever._filters == {}
     assert retriever._top_k == 10
-    assert retriever._alpha == DEFAULT_ALPHA
+    assert retriever._alpha == 0.7
     assert retriever._max_vector_distance is None
 
 
@@ -205,7 +204,7 @@ def test_run_basic():
         query_embedding=[0.1, 0.2, 0.3],
         filters={},
         top_k=10,
-        alpha=DEFAULT_ALPHA,
+        alpha=0.7,
         max_vector_distance=None,
     )
 
@@ -223,7 +222,7 @@ def test_run_with_runtime_filters():
         query_embedding=[0.1, 0.2, 0.3],
         filters={"runtime": "filter"},
         top_k=10,
-        alpha=DEFAULT_ALPHA,
+        alpha=0.7,
         max_vector_distance=None,
     )
 
@@ -265,7 +264,7 @@ def test_run_empty_query():
     assert "documents" in result
     assert len(result["documents"]) == 0
     mock_document_store._hybrid_retrieval.assert_called_once_with(
-        query="", query_embedding=[0.1, 0.2, 0.3], filters={}, top_k=10, alpha=DEFAULT_ALPHA, max_vector_distance=None
+        query="", query_embedding=[0.1, 0.2, 0.3], filters={}, top_k=10, alpha=0.7, max_vector_distance=None
     )
 
 
@@ -294,7 +293,7 @@ def test_from_dict_no_filter_policy(_mock_weaviate):
             "init_parameters": {
                 "filters": {},
                 "top_k": 10,
-                "alpha": DEFAULT_ALPHA,
+                "alpha": 0.7,
                 "max_vector_distance": None,
                 # filter_policy intentionally omitted
                 "document_store": {
@@ -324,7 +323,7 @@ def test_from_dict_no_filter_policy(_mock_weaviate):
     assert retriever._document_store
     assert retriever._filters == {}
     assert retriever._top_k == 10
-    assert retriever._alpha == DEFAULT_ALPHA
+    assert retriever._alpha == 0.7
     assert retriever._max_vector_distance is None
     assert retriever._filter_policy == FilterPolicy.REPLACE
 
@@ -387,7 +386,7 @@ def test_run_with_max_vector_distance_zero_runtime():
         query_embedding=[0.1, 0.2],
         filters={},
         top_k=10,
-        alpha=DEFAULT_ALPHA,
+        alpha=0.7,
         max_vector_distance=0.0,
     )
 
@@ -408,7 +407,7 @@ def test_run_with_max_vector_distance_zero_init_and_none_runtime():
         query_embedding=[0.1, 0.2],
         filters={},
         top_k=10,
-        alpha=DEFAULT_ALPHA,
+        alpha=0.7,
         max_vector_distance=0.0,
     )