Commit 1762a72
committed
fix: AmazonBedrockDocumentEmbedder to not modify Documents in place (#2174)
- Add dataclasses.replace import
- Update _embed_cohere to create new document instances
- Update _embed_titan to create new document instances
- Add immutability tests for both Cohere and Titan paths
- Update CHANGELOG.md with bug fix entry
Follows the pattern from FastEmbed, Optimum, and Nvidia integrations.1 parent 1017c72 commit 1762a72
3 files changed
Lines changed: 87 additions & 39 deletions
File tree
- integrations/amazon_bedrock
- src/haystack_integrations/components/embedders/amazon_bedrock
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
3 | 9 | | |
4 | 10 | | |
5 | 11 | | |
6 | 12 | | |
7 | 13 | | |
8 | 14 | | |
9 | | - | |
10 | 15 | | |
11 | 16 | | |
12 | 17 | | |
| |||
27 | 32 | | |
28 | 33 | | |
29 | 34 | | |
30 | | - | |
31 | 35 | | |
32 | 36 | | |
33 | 37 | | |
| |||
57 | 61 | | |
58 | 62 | | |
59 | 63 | | |
60 | | - | |
61 | 64 | | |
62 | 65 | | |
63 | 66 | | |
| |||
67 | 70 | | |
68 | 71 | | |
69 | 72 | | |
70 | | - | |
71 | 73 | | |
72 | 74 | | |
73 | 75 | | |
| |||
84 | 86 | | |
85 | 87 | | |
86 | 88 | | |
87 | | - | |
88 | 89 | | |
89 | 90 | | |
90 | 91 | | |
| |||
100 | 101 | | |
101 | 102 | | |
102 | 103 | | |
103 | | - | |
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | | - | |
121 | 120 | | |
122 | 121 | | |
123 | 122 | | |
124 | 123 | | |
125 | 124 | | |
126 | 125 | | |
127 | | - | |
128 | 126 | | |
129 | 127 | | |
130 | 128 | | |
| |||
136 | 134 | | |
137 | 135 | | |
138 | 136 | | |
139 | | - | |
140 | 137 | | |
141 | 138 | | |
142 | 139 | | |
| |||
154 | 151 | | |
155 | 152 | | |
156 | 153 | | |
157 | | - | |
158 | 154 | | |
159 | 155 | | |
160 | 156 | | |
161 | 157 | | |
162 | 158 | | |
163 | 159 | | |
164 | | - | |
165 | 160 | | |
166 | 161 | | |
167 | 162 | | |
168 | 163 | | |
169 | 164 | | |
170 | 165 | | |
171 | | - | |
172 | 166 | | |
173 | 167 | | |
174 | 168 | | |
| |||
183 | 177 | | |
184 | 178 | | |
185 | 179 | | |
186 | | - | |
187 | 180 | | |
188 | 181 | | |
189 | 182 | | |
| |||
205 | 198 | | |
206 | 199 | | |
207 | 200 | | |
208 | | - | |
209 | 201 | | |
210 | 202 | | |
211 | 203 | | |
| |||
224 | 216 | | |
225 | 217 | | |
226 | 218 | | |
227 | | - | |
228 | 219 | | |
229 | 220 | | |
230 | 221 | | |
| |||
235 | 226 | | |
236 | 227 | | |
237 | 228 | | |
238 | | - | |
239 | 229 | | |
240 | 230 | | |
241 | 231 | | |
| |||
246 | 236 | | |
247 | 237 | | |
248 | 238 | | |
249 | | - | |
250 | 239 | | |
251 | 240 | | |
252 | 241 | | |
253 | 242 | | |
254 | 243 | | |
255 | 244 | | |
256 | | - | |
257 | 245 | | |
258 | 246 | | |
259 | 247 | | |
| |||
275 | 263 | | |
276 | 264 | | |
277 | 265 | | |
278 | | - | |
279 | 266 | | |
280 | 267 | | |
281 | 268 | | |
282 | 269 | | |
283 | | - | |
| 270 | + | |
284 | 271 | | |
285 | 272 | | |
286 | 273 | | |
287 | 274 | | |
288 | | - | |
289 | | - | |
| 275 | + | |
290 | 276 | | |
291 | 277 | | |
292 | 278 | | |
293 | 279 | | |
294 | 280 | | |
295 | 281 | | |
296 | 282 | | |
297 | | - | |
298 | 283 | | |
299 | 284 | | |
300 | 285 | | |
| |||
307 | 292 | | |
308 | 293 | | |
309 | 294 | | |
310 | | - | |
311 | 295 | | |
312 | 296 | | |
313 | 297 | | |
314 | 298 | | |
315 | 299 | | |
316 | 300 | | |
317 | | - | |
318 | 301 | | |
319 | 302 | | |
320 | 303 | | |
321 | 304 | | |
322 | 305 | | |
323 | 306 | | |
324 | | - | |
325 | 307 | | |
326 | 308 | | |
327 | 309 | | |
328 | 310 | | |
329 | 311 | | |
330 | | - | |
| 312 | + | |
331 | 313 | | |
332 | 314 | | |
333 | 315 | | |
| |||
347 | 329 | | |
348 | 330 | | |
349 | 331 | | |
350 | | - | |
351 | 332 | | |
352 | 333 | | |
353 | 334 | | |
354 | 335 | | |
355 | 336 | | |
356 | 337 | | |
357 | | - | |
358 | 338 | | |
359 | 339 | | |
360 | 340 | | |
361 | 341 | | |
362 | 342 | | |
363 | 343 | | |
364 | | - | |
365 | 344 | | |
366 | 345 | | |
367 | 346 | | |
368 | 347 | | |
369 | | - | |
| 348 | + | |
370 | 349 | | |
371 | 350 | | |
372 | 351 | | |
| |||
379 | 358 | | |
380 | 359 | | |
381 | 360 | | |
382 | | - | |
| 361 | + | |
383 | 362 | | |
384 | 363 | | |
385 | 364 | | |
| |||
391 | 370 | | |
392 | 371 | | |
393 | 372 | | |
394 | | - | |
395 | 373 | | |
396 | 374 | | |
397 | 375 | | |
| |||
402 | 380 | | |
403 | 381 | | |
404 | 382 | | |
405 | | - | |
406 | 383 | | |
407 | 384 | | |
408 | 385 | | |
| |||
466 | 443 | | |
467 | 444 | | |
468 | 445 | | |
469 | | - | |
| 446 | + | |
470 | 447 | | |
471 | 448 | | |
472 | 449 | | |
| |||
Lines changed: 7 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
186 | 187 | | |
187 | 188 | | |
188 | 189 | | |
| 190 | + | |
189 | 191 | | |
190 | | - | |
| 192 | + | |
191 | 193 | | |
192 | | - | |
| 194 | + | |
193 | 195 | | |
194 | 196 | | |
195 | 197 | | |
| |||
214 | 216 | | |
215 | 217 | | |
216 | 218 | | |
| 219 | + | |
217 | 220 | | |
218 | | - | |
| 221 | + | |
219 | 222 | | |
220 | | - | |
| 223 | + | |
221 | 224 | | |
222 | 225 | | |
223 | 226 | | |
| |||
Lines changed: 68 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
257 | 257 | | |
258 | 258 | | |
259 | 259 | | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
260 | 328 | | |
261 | 329 | | |
262 | 330 | | |
| |||
0 commit comments