Skip to content

Commit 31219dc

Browse files
committed
async test
1 parent 507ba0e commit 31219dc

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

integrations/chroma/tests/test_document_store_async.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ async def test_client_settings_applied_async(self):
107107
await store._ensure_initialized_async()
108108
assert store._async_client.get_settings().anonymized_telemetry is False
109109

110-
async def test_invalid_client_settings_async(self):
110+
async def test_invalid_client_settings_are_ignored_async(self):
111111
store = ChromaDocumentStore(
112112
host="localhost",
113113
port=8000,
@@ -117,8 +117,10 @@ async def test_invalid_client_settings_async(self):
117117
},
118118
collection_name=f"{uuid.uuid1()}-async-invalid",
119119
)
120-
with pytest.raises(ValueError, match="Invalid client_settings"):
121-
await store._ensure_initialized_async()
120+
await store._ensure_initialized_async()
121+
settings = store._async_client.get_settings()
122+
assert not hasattr(settings, "invalid_setting_name")
123+
assert not hasattr(settings, "another_fake_setting")
122124

123125
async def test_search_async(self):
124126
document_store = ChromaDocumentStore(host="localhost", port=8000, collection_name="my_custom_collection")

0 commit comments

Comments
 (0)