small adjustment in the tests

Author: davidsbatista

integrations/sqlalchemy/src/haystack_integrations/components/retrievers/sqlalchemy/sqlalchemy_table_retriever.py

@@ -162,7 +162,7 @@ def run(self, query: str) -> dict[str, Any]:
             logger.warning("Query is not a string, returning empty DataFrame")
             return {"dataframe": DataFrame(), "table": "", "error": "query is not a string"}
 
-        if not query:
+        if not query.strip():
             return {"dataframe": DataFrame(), "table": "", "error": "empty query"}
 
         if not self._warmed_up:

integrations/sqlalchemy/tests/test_sqlalchemy_table_retriever.py

@@ -43,10 +43,12 @@ def test_init_all_params(self):
 class TestSQLAlchemyTableRetrieverSerialization:
     def test_to_dict(self):
         password = Secret.from_env_var("DB_PASSWORD")
+        init_script = ["CREATE TABLE t (x INTEGER)", "INSERT INTO t VALUES (1)"]
         retriever = SQLAlchemyTableRetriever(
             drivername="sqlite",
             database=":memory:",
             password=password,
+            init_script=init_script,
         )
         d = retriever.to_dict()
         expected_type = (
@@ -57,21 +59,25 @@ def test_to_dict(self):
         assert params["drivername"] == "sqlite"
         assert params["database"] == ":memory:"
         assert params["password"]["type"] == "env_var"
+        assert params["init_script"] == init_script
 
     def test_from_dict(self, monkeypatch):
         monkeypatch.setenv("DB_PASSWORD", "secret")
         password = Secret.from_env_var("DB_PASSWORD")
+        init_script = ["CREATE TABLE t (x INTEGER)", "INSERT INTO t VALUES (1)"]
         retriever = SQLAlchemyTableRetriever(
             drivername="sqlite",
             database=":memory:",
             password=password,
+            init_script=init_script,
         )
         d = retriever.to_dict()
         restored = SQLAlchemyTableRetriever.from_dict(d)
         assert restored.drivername == "sqlite"
         assert restored.database == ":memory:"
         assert restored.password is not None
         assert restored.password.resolve_value() == "secret"
+        assert restored.init_script == init_script
 
 
 class TestSQLAlchemyTableRetrieverRun:
@@ -99,9 +105,10 @@ def test_run_non_string_query(self):
         assert result["dataframe"].empty
         assert result["table"] == ""
 
-    def test_run_empty_query(self):
+    @pytest.mark.parametrize("query", ["", "   ", "\t", "\n"])
+    def test_run_empty_query(self, query):
         retriever = SQLAlchemyTableRetriever(drivername="sqlite", database=":memory:")
-        result = retriever.run(query="")
+        result = retriever.run(query=query)
         assert result["error"] == "empty query"
         assert result["dataframe"].empty
         assert result["table"] == ""
@@ -151,18 +158,6 @@ def test_max_row_limit(self, monkeypatch):
         result = retriever.run(query="SELECT * FROM t")
         assert len(result["dataframe"]) == 2
 
-    def test_warm_up_with_init_script(self):
-        init_sql = ["CREATE TABLE greetings (msg TEXT)", "INSERT INTO greetings VALUES ('hello')"]
-        retriever = SQLAlchemyTableRetriever(
-            drivername="sqlite",
-            database=":memory:",
-            init_script=init_sql,
-        )
-        retriever.warm_up()
-        result = retriever.run(query="SELECT * FROM greetings")
-        assert not result["dataframe"].empty
-        assert result["dataframe"].iloc[0]["msg"] == "hello"
-
     def test_warm_up_idempotent(self):
         retriever = SQLAlchemyTableRetriever(drivername="sqlite", database=":memory:")
         retriever.warm_up()