chore: Remove ruff exclude and fix linting in Langfuse integration (#2257)

* Remove excludes for langfuse and fix linting

* Fix linting in example folder

* Update timezone

* Post merge formatting

---------

Co-authored-by: Vladimir Blagojevic <dovlex@gmail.com>

Author: sjrl

integrations/langfuse/example/basic_rag.py

@@ -62,5 +62,5 @@ def get_pipeline(document_store: InMemoryDocumentStore):
     question = "What does Rhodes Statue look like?"
     response = pipeline.run({"text_embedder": {"text": question}, "prompt_builder": {"question": question}})
 
-    print(response["llm"]["replies"][0])
-    print(response["tracer"]["trace_url"])
+    print(response["llm"]["replies"][0])  # noqa: T201
+    print(response["tracer"]["trace_url"])  # noqa: T201

integrations/langfuse/example/chat.py

@@ -36,7 +36,6 @@
 selected_chat_generator = generators[selected_chat_generator]()
 
 if __name__ == "__main__":
-
     pipe = Pipeline()
     pipe.add_component("tracer", LangfuseConnector("Chat example"))
     pipe.add_component("prompt_builder", ChatPromptBuilder())
@@ -60,5 +59,5 @@
             },
         }
     )
-    print(response["llm"]["replies"][0])
-    print(response["tracer"]["trace_url"])
+    print(response["llm"]["replies"][0])  # noqa: T201
+    print(response["tracer"]["trace_url"])  # noqa: T201

integrations/langfuse/pyproject.toml

@@ -93,7 +93,6 @@ allow-direct-references = true
 [tool.ruff]
 target-version = "py38"
 line-length = 120
-exclude = ["example", "tests"]
 
 [tool.ruff.lint]
 select = [

integrations/langfuse/tests/test_tracer.py

@@ -6,12 +6,10 @@
 import datetime
 import logging
 import sys
-import json
 from typing import Optional
 from unittest.mock import MagicMock, Mock, patch
 
 import pytest
-from haystack import Pipeline, component
 from haystack.dataclasses import ChatMessage, ToolCall
 
 from haystack_integrations.tracing.langfuse.tracer import (
@@ -21,7 +19,6 @@
     LangfuseTracer,
     SpanContext,
 )
-from haystack_integrations.components.connectors.langfuse import LangfuseConnector
 
 
 # Mock functions for Langfuse v3 API
@@ -78,7 +75,7 @@ def end(self):
 
 
 class MockTracer:
-    def trace(self, name, **kwargs):
+    def trace(self, name, **kwargs):  # noqa: ARG002
         # Return a unique mock span for each trace call
         return MockSpan(name=name)
 
@@ -92,10 +89,10 @@ class MockLangfuseClient:
     def __init__(self):
         self._mock_context_manager = MockContextManager()
 
-    def start_as_current_span(self, name=None, **kwargs):
+    def start_as_current_span(self, _name=None, **_kwargs):
         return self._mock_context_manager
 
-    def start_as_current_observation(self, name=None, as_type=None, **kwargs):
+    def start_as_current_observation(self, _name=None, _as_type=None, **_kwargs):
         return self._mock_context_manager
 
     def get_current_trace_id(self):
@@ -230,7 +227,9 @@ def test_handle_chat_generator(self):
         assert mock_span.update.call_args_list[0][1] == {
             "usage": None,
             "model": "test_model",
-            "completion_start_time": datetime.datetime(2021, 7, 27, 16, 2, 8, 12345),
+            "completion_start_time": datetime.datetime(  # noqa: DTZ001
+                2021, 7, 27, 16, 2, 8, 12345
+            ),
         }
 
     def test_handle_bad_completion_start_time(self, caplog):
@@ -302,18 +301,15 @@ def test_create_new_span(self):
         mock_raw_span.operation_name = "operation_name"
         mock_raw_span.metadata = {"tag1": "value1", "tag2": "value2"}
 
-        with patch("haystack_integrations.tracing.langfuse.tracer.LangfuseSpan") as MockLangfuseSpan, patch(
-            "haystack_integrations.tracing.langfuse.tracer.langfuse.get_client"
-        ) as mock_get_client:
-            mock_span_instance = MockLangfuseSpan.return_value
+        with patch("haystack_integrations.tracing.langfuse.tracer.LangfuseSpan") as mock_langfuse_span:
+            mock_span_instance = mock_langfuse_span.return_value
             mock_span_instance.raw_span.return_value = mock_raw_span
 
-            mock_client = mock_get_client()
             mock_context_manager = MockContextManager()
             mock_context_manager._span = mock_raw_span
-            mock_client.start_as_current_span.return_value = mock_context_manager
-
             mock_tracer = MagicMock()
+            mock_tracer.start_as_current_span.return_value = mock_context_manager
+
             tracer = LangfuseTracer(tracer=mock_tracer, name="Haystack", public=False)
 
             # check that the trace method is called on the tracer instance with the provided operation name and tags
@@ -329,9 +325,7 @@ def test_create_new_span(self):
 
     # check that update method is called on the span instance with the provided key value pairs
     def test_update_span_with_pipeline_input_output_data(self):
-        with patch("haystack_integrations.tracing.langfuse.tracer.langfuse.get_client") as mock_get_client:
-            mock_client = mock_get_client()
-
+        with patch("haystack_integrations.tracing.langfuse.tracer.langfuse.get_client"):
             tracer = LangfuseTracer(tracer=MockLangfuseClient(), name="Haystack", public=False)
             with tracer.trace(operation_name="operation_name", tags={"haystack.pipeline.input_data": "hello"}) as span:
                 assert span.raw_span()._data["metadata"] == {"haystack.pipeline.input_data": "hello"}
@@ -340,9 +334,7 @@ def test_update_span_with_pipeline_input_output_data(self):
                 assert span.raw_span()._data["metadata"] == {"haystack.pipeline.output_data": "bye"}
 
     def test_trace_generation(self):
-        with patch("haystack_integrations.tracing.langfuse.tracer.langfuse.get_client") as mock_get_client:
-            mock_client = mock_get_client()
-
+        with patch("haystack_integrations.tracing.langfuse.tracer.langfuse.get_client"):
             tracer = LangfuseTracer(tracer=MockLangfuseClient(), name="Haystack", public=False)
             tags = {
                 "haystack.component.type": "OpenAIChatGenerator",
@@ -358,7 +350,7 @@ def test_trace_generation(self):
                 ...
             assert span.raw_span()._data["usage"] is None
             assert span.raw_span()._data["model"] == "test_model"
-            assert span.raw_span()._data["completion_start_time"] == datetime.datetime(2021, 7, 27, 16, 2, 8, 12345)
+            assert span.raw_span()._data["completion_start_time"] == datetime.datetime(2021, 7, 27, 16, 2, 8, 12345)  # noqa: DTZ001
 
     def test_handle_tool_invoker(self):
         """
@@ -402,7 +394,7 @@ def test_handle_tool_invoker(self):
         updated_name = name_update_call[1]["name"]
 
         # verify the format of the updated span name to be: `original_component_name - [list_of_tool_names]`
-        assert updated_name != "tool_invoker", f"Expected 'tool_invoker` to be upddated with tool names"
+        assert updated_name != "tool_invoker", "Expected 'tool_invoker` to be upddated with tool names"
         assert " - " in updated_name, f"Expected ' - ' in {updated_name}"
         assert "[" in updated_name, f"Expected '[' in {updated_name}"
         assert "]" in updated_name, f"Expected ']' in {updated_name}"
@@ -411,9 +403,7 @@ def test_handle_tool_invoker(self):
         assert "weather_tool" in updated_name, f"Expected 'weather_tool' in {updated_name}"
 
     def test_trace_generation_invalid_start_time(self):
-        with patch("haystack_integrations.tracing.langfuse.tracer.langfuse.get_client") as mock_get_client:
-            mock_client = mock_get_client()
-
+        with patch("haystack_integrations.tracing.langfuse.tracer.langfuse.get_client"):
             tracer = LangfuseTracer(tracer=MockLangfuseClient(), name="Haystack", public=False)
             tags = {
                 "haystack.component.type": "OpenAIChatGenerator",
@@ -434,7 +424,7 @@ def test_update_span_gets_flushed_by_default(self):
         tracer_mock.flush = Mock()  # Make flush a mock for assertions
 
         tracer = LangfuseTracer(tracer=tracer_mock, name="Haystack", public=False)
-        with tracer.trace(operation_name="operation_name", tags={"haystack.pipeline.input_data": "hello"}) as span:
+        with tracer.trace(operation_name="operation_name", tags={"haystack.pipeline.input_data": "hello"}):
             pass
 
         tracer_mock.flush.assert_called_once()
@@ -444,10 +434,11 @@ def test_update_span_flush_disable(self, monkeypatch):
         tracer_mock = MockLangfuseClient()
         tracer_mock.flush = Mock()  # Make flush a mock for assertions
 
-        from haystack_integrations.tracing.langfuse.tracer import LangfuseTracer
+        # Re-import LangfuseTracer to ensure it picks up the new environment variable
+        from haystack_integrations.tracing.langfuse.tracer import LangfuseTracer  # noqa: PLC0415
 
         tracer = LangfuseTracer(tracer=tracer_mock, name="Haystack", public=False)
-        with tracer.trace(operation_name="operation_name", tags={"haystack.pipeline.input_data": "hello"}) as span:
+        with tracer.trace(operation_name="operation_name", tags={"haystack.pipeline.input_data": "hello"}):
             pass
 
         tracer_mock.flush.assert_not_called()
@@ -456,7 +447,7 @@ def test_context_is_empty_after_tracing(self):
         tracer_mock = MockLangfuseClient()
 
         tracer = LangfuseTracer(tracer=tracer_mock, name="Haystack", public=False)
-        with tracer.trace(operation_name="operation_name", tags={"haystack.pipeline.input_data": "hello"}) as span:
+        with tracer.trace(operation_name="operation_name", tags={"haystack.pipeline.input_data": "hello"}):
             pass
 
         # Check behavioral state instead of internal _context list
@@ -471,7 +462,7 @@ def test_init_with_tracing_disabled(self, monkeypatch, caplog):
         # Re-import LangfuseTracer and instantiate it with tracing disabled
         with caplog.at_level(logging.WARNING):
             monkeypatch.setenv("HAYSTACK_CONTENT_TRACING_ENABLED", "false")
-            from haystack_integrations.tracing.langfuse import LangfuseTracer
+            from haystack_integrations.tracing.langfuse import LangfuseTracer  # noqa: PLC0415
 
             LangfuseTracer(tracer=MockLangfuseClient(), name="Haystack", public=False)
             assert "tracing is disabled" in caplog.text

integrations/langfuse/tests/test_tracing.py

@@ -2,11 +2,11 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
+import json
 import os
 import time
 from typing import Any, Dict, List
 from urllib.parse import urlparse
-import json
 
 import pytest
 import requests
@@ -38,7 +38,7 @@ def poll_langfuse(url: str):
 
     res = None
     while attempts > 0:
-        res = requests.get(url, auth=auth)
+        res = requests.get(url, auth=auth, timeout=60.0)
         if res.status_code == 200:
             return res
 
@@ -73,7 +73,7 @@ def basic_pipeline(llm_class, expected_trace):
         (CohereChatGenerator, "COHERE_API_KEY", "Cohere"),
     ],
 )
-def test_tracing_integration(llm_class, env_var, expected_trace, basic_pipeline):
+def test_tracing_integration(env_var, expected_trace, basic_pipeline):
     if not all([os.environ.get("LANGFUSE_SECRET_KEY"), os.environ.get("LANGFUSE_PUBLIC_KEY"), os.environ.get(env_var)]):
         pytest.skip(f"Missing required environment variable: {env_var}")
 
@@ -242,7 +242,7 @@ def run(self, input_data: str):
     # Test 1: First run will fail and should clean up context
     try:
         main_pipeline.run({"nested_component": {"input_data": "invalid json"}})
-    except Exception:
+    except Exception:  # noqa: S110
         pass  # Expected to fail
 
     # Critical assertion: context should be empty after failed operation