Skip to content

Commit 3b45d65

Browse files
committed
feat: fix: resolve CI failures on Windows/macOS and lowest-deps runs
1 parent f93b0e2 commit 3b45d65

3 files changed

Lines changed: 15 additions & 4 deletions

File tree

.github/workflows/falkor_db.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,11 @@ jobs:
5959
matrix:
6060
os: ${{ fromJSON(needs.compute-test-matrix.outputs.os) }}
6161
python-version: ${{ fromJSON(needs.compute-test-matrix.outputs.python-version) }}
62+
# Docker services are only supported on Linux GitHub Actions runners.
63+
# Windows and macOS runners do not support the `services:` block.
6264
services:
6365
falkordb:
64-
image: falkordb/falkordb:latest
66+
image: ${{ runner.os == 'Linux' && 'falkordb/falkordb:latest' || '' }}
6567
ports:
6668
- 6379:6379
6769
options: >-
@@ -112,6 +114,9 @@ jobs:
112114
path: python-coverage-comment-action-falkor_db.txt
113115

114116
- name: Run integration tests
117+
# Integration tests require a live FalkorDB instance via Docker.
118+
# Docker services are only available on Linux runners.
119+
if: runner.os == 'Linux'
115120
env:
116121
FALKORDB_HOST: localhost
117122
FALKORDB_PORT: 6379

integrations/falkor_db/pyproject.toml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,14 @@ dependencies = ["haystack-pydoc-tools", "ruff"]
4949

5050
[tool.hatch.envs.default.scripts]
5151
docs = ["haystack-pydoc pydoc/config_docusaurus.yml"]
52-
fmt = "ruff check --fix {args}; ruff format {args}"
53-
fmt-check = "ruff check {args} && ruff format --check {args}"
52+
fmt = [
53+
"ruff check --fix {args}",
54+
"ruff format {args}",
55+
]
56+
fmt-check = [
57+
"ruff check {args}",
58+
"ruff format --check {args}",
59+
]
5460

5561
[tool.hatch.envs.test]
5662
dependencies = [

integrations/falkor_db/src/haystack_integrations/components/retrievers/falkor_db/embedding_retriever.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
from haystack import component, default_from_dict, default_to_dict
88
from haystack.dataclasses import Document
9-
from haystack.document_stores.types.filter_policy import FilterPolicy, apply_filter_policy
9+
from haystack.document_stores.types import FilterPolicy, apply_filter_policy
1010

1111
from haystack_integrations.document_stores.falkor_db import FalkorDBDocumentStore
1212

0 commit comments

Comments
 (0)