test: test invalid client settings are ignored

Author: anakin87

integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py

@@ -114,11 +114,7 @@ def _ensure_initialized(self):
             # Use dict to conditionally pass settings because Chroma doesn't accept settings=None
             client_kwargs: dict[str, Any] = {}
             if self._client_settings:
-                try:
-                    client_kwargs["settings"] = Settings(**self._client_settings)
-                except ValueError as e:
-                    msg = f"Invalid client_settings ({self._client_settings}): {e}"
-                    raise ValueError(msg) from e
+                client_kwargs["settings"] = Settings(**self._client_settings)
 
             if self._host and self._port is not None:
                 # Remote connection via HTTP client
@@ -170,11 +166,7 @@ async def _ensure_initialized_async(self):
             # Use dict to conditionally pass settings because Chroma doesn't accept settings=None
             client_kwargs: dict[str, Any] = {}
             if self._client_settings:
-                try:
-                    client_kwargs["settings"] = Settings(**self._client_settings)
-                except ValueError as e:
-                    msg = f"Invalid client_settings ({self._client_settings}): {e}"
-                    raise ValueError(msg) from e
+                client_kwargs["settings"] = Settings(**self._client_settings)
 
             client = await chromadb.AsyncHttpClient(
                 host=self._host,

integrations/chroma/tests/test_document_store.py

@@ -124,15 +124,17 @@ def test_client_settings_applied(self, clear_chroma_system_cache):
         store._ensure_initialized()
         assert store._client.get_settings().anonymized_telemetry is False
 
-    def test_invalid_client_settings(self, clear_chroma_system_cache):
+    def test_invalid_client_settings_are_ignored(self, clear_chroma_system_cache):
         store = ChromaDocumentStore(
             client_settings={
                 "invalid_setting_name": "some_value",
                 "another_fake_setting": 123,
             }
         )
-        with pytest.raises(ValueError, match="Invalid client_settings"):
-            store._ensure_initialized()
+        store._ensure_initialized()
+        settings = store._client.get_settings()
+        assert not hasattr(settings, "invalid_setting_name")
+        assert not hasattr(settings, "another_fake_setting")
 
     def test_to_dict(self, request):
         ds = ChromaDocumentStore(