Skip to content

Commit 5684e43

Browse files
HuyDCdavidsbatista
andauthored
fix: replace in place dataclass mutations for pgvector #11087 (#3142)
* fix: use replace to set attr to None [11087] * fix: avoid linting error reassigning loop vars [11087] --------- Co-authored-by: David S. Batista <dsbatista@gmail.com>
1 parent 7ffe748 commit 5684e43

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

integrations/pgvector/tests/test_filters.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
#
33
# SPDX-License-Identifier: Apache-2.0
44

5+
from dataclasses import replace
6+
57
import pytest
68
from haystack.dataclasses.document import Document
79
from haystack.testing.document_store import FilterDocumentsTest
@@ -42,8 +44,9 @@ def assert_documents_are_equal(self, received: list[Document], expected: list[Do
4244
else:
4345
assert received_doc.embedding == pytest.approx(expected_doc.embedding)
4446

45-
received_doc.embedding, expected_doc.embedding = None, None
46-
assert received_doc == expected_doc
47+
received_doc_no_embedding = replace(received_doc, embedding=None)
48+
expected_doc_no_embedding = replace(expected_doc, embedding=None)
49+
assert received_doc_no_embedding == expected_doc_no_embedding
4750

4851
@pytest.mark.skip(reason="NOT operator is not supported in PgvectorDocumentStore")
4952
def test_not_operator(self, document_store, filterable_docs): ...

0 commit comments

Comments
 (0)