Skip to content

Commit 57e8f4e

Browse files
committed
_write_async should only return number of documents written
1 parent 4e2cd24 commit 57e8f4e

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

  • integrations/weaviate/src/haystack_integrations/document_stores/weaviate

integrations/weaviate/src/haystack_integrations/document_stores/weaviate/document_store.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1044,6 +1044,7 @@ async def _write_async(self, documents: list[Document], policy: DuplicatePolicy)
10441044
"""
10451045
collection = await self.async_collection
10461046

1047+
written = 0
10471048
duplicate_errors_ids = []
10481049
for doc in documents:
10491050
if not isinstance(doc, Document):
@@ -1063,14 +1064,15 @@ async def _write_async(self, documents: list[Document], policy: DuplicatePolicy)
10631064
vector=doc.embedding,
10641065
)
10651066

1067+
written += 1
10661068
except weaviate.exceptions.UnexpectedStatusCodeError:
10671069
if policy == DuplicatePolicy.FAIL:
10681070
duplicate_errors_ids.append(doc.id)
10691071

10701072
if duplicate_errors_ids:
10711073
msg = f"IDs '{', '.join(duplicate_errors_ids)}' already exist in the document store."
10721074
raise DuplicateDocumentError(msg)
1073-
return len(documents)
1075+
return written
10741076

10751077
def write_documents(self, documents: list[Document], policy: DuplicatePolicy = DuplicatePolicy.NONE) -> int:
10761078
"""

0 commit comments

Comments
 (0)