fix(supabase): fix lint errors - imports, assert, formatting

Author: ShubhamGond105

integrations/supabase/src/haystack_integrations/components/retrievers/supabase/groonga_retriever.py

@@ -108,7 +108,7 @@ async def run_async(
         top_k: int | None = None,
     ) -> dict[str, list[Document]]:
         """
-        Async version of run(). 
+        Async version of run().
 
         Note: supabase-py's sync client does not support native async queries.
         This method runs the synchronous retrieval and returns the result.
@@ -162,4 +162,4 @@ def from_dict(cls, data: dict[str, Any]) -> "SupabaseGroongaRetriever":
         data["init_parameters"]["document_store"] = SupabaseGroongaDocumentStore.from_dict(doc_store_params)
         if filter_policy := data["init_parameters"].get("filter_policy"):
             data["init_parameters"]["filter_policy"] = FilterPolicy.from_str(filter_policy)
-        return default_from_dict(cls, data)
+        return default_from_dict(cls, data)

integrations/supabase/src/haystack_integrations/document_stores/supabase/groonga_document_store.py

@@ -2,15 +2,15 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-from typing import Any, Optional
+from typing import Any
 
 from haystack import default_from_dict, default_to_dict, logging
 from haystack.dataclasses import Document
 from haystack.document_stores.errors import DuplicateDocumentError
 from haystack.document_stores.types import DocumentStore, DuplicatePolicy
 from haystack.utils.auth import Secret, deserialize_secrets_inplace
 
-from supabase import create_client, Client
+from supabase import Client, create_client
 
 logger = logging.getLogger(__name__)
 
@@ -70,7 +70,7 @@ def __init__(
         self.recreate_table = recreate_table
 
         # Client is initialized lazily in warm_up()
-        self._client: Optional[Client] = None
+        self._client: Client | None = None
 
     def warm_up(self) -> None:
         """
@@ -88,7 +88,9 @@ def _setup_table(self) -> None:
 
         If recreate_table is True, drops and recreates the table.
         """
-        assert self._client is not None, "Call warm_up() before using the document store."
+        if self._client is None:
+            msg = "Call warm_up() before using the document store."
+            raise RuntimeError(msg)
 
         if self.recreate_table:
             self._client.rpc("exec_sql", {"query": f"DROP TABLE IF EXISTS {self.table_name};"}).execute()
@@ -118,7 +120,9 @@ def count_documents(self) -> int:
 
         :returns: Number of documents.
         """
-        assert self._client is not None, "Call warm_up() before using the document store."
+        if self._client is None:
+            msg = "Call warm_up() before using the document store."
+            raise RuntimeError(msg)
         result = self._client.table(self.table_name).select("*", count="exact").execute()
         return int(result.count) if result.count is not None else 0
 
@@ -128,10 +132,13 @@ def filter_documents(self, filters: dict[str, Any] | None = None) -> list[Docume
 
         Supported filters: equality filters on `id`, `content`, and `meta` fields.
 
-        :param filters: Optional dictionary of filters. Example: {"field": "meta.language", "operator": "==", "value": "en"}
+        :param filters: Optional dictionary of filters.
+            Example: ``{"field": "meta.language", "operator": "==", "value": "en"}``
         :returns: List of matching Document objects.
         """
-        assert self._client is not None, "Call warm_up() before using the document store."
+        if self._client is None:
+            msg = "Call warm_up() before using the document store."
+            raise RuntimeError(msg)
 
         query = self._client.table(self.table_name).select("*")
 
@@ -149,7 +156,6 @@ def _apply_filters(self, query: Any, filters: dict[str, Any]) -> Any:
         :param filters: Dictionary of filters to apply.
         :returns: The query with filters applied.
         """
-        operator = filters.get("operator", "AND")
         conditions = filters.get("conditions", [])
 
         for condition in conditions:
@@ -159,13 +165,12 @@ def _apply_filters(self, query: Any, filters: dict[str, Any]) -> Any:
 
             # Handle nested meta fields e.g. "meta.language"
             if field.startswith("meta."):
-                meta_key = field[len("meta."):]
+                meta_key = field[len("meta.") :]
                 if op == "==":
                     query = query.eq(f"meta->>'{meta_key}'", value)
                 elif op == "!=":
                     query = query.neq(f"meta->>'{meta_key}'", value)
-            else:
-                if op == "==":
+                elif op == "==":
                     query = query.eq(field, value)
                 elif op == "!=":
                     query = query.neq(field, value)
@@ -186,7 +191,9 @@ def write_documents(
         :param policy: How to handle duplicate documents. Defaults to DuplicatePolicy.FAIL.
         :returns: Number of documents written.
         """
-        assert self._client is not None, "Call warm_up() before using the document store."
+        if self._client is None:
+            msg = "Call warm_up() before using the document store."
+            raise RuntimeError(msg)
 
         if not documents:
             return 0
@@ -226,7 +233,9 @@ def delete_documents(self, document_ids: list[str]) -> None:
 
         :param document_ids: List of document IDs to delete.
         """
-        assert self._client is not None, "Call warm_up() before using the document store."
+        if self._client is None:
+            msg = "Call warm_up() before using the document store."
+            raise RuntimeError(msg)
 
         if not document_ids:
             return
@@ -246,10 +255,13 @@ def _groonga_retrieval(
         :param filters: Optional filters to apply after retrieval.
         :returns: List of matching Document objects ranked by relevance.
         """
-        assert self._client is not None, "Call warm_up() before using the document store."
+        if self._client is None:
+            msg = "Call warm_up() before using the document store."
+            raise RuntimeError(msg)
 
         result = self._client.rpc(
-            "groonga_search", {"query_text": query, "table": self.table_name, "top_k": top_k}
+            "groonga_search",
+            {"query_text": query, "table": self.table_name, "top_k": top_k},
         ).execute()
 
         documents = [self._to_haystack_document(row) for row in (result.data or []) if isinstance(row, dict)]
@@ -279,7 +291,7 @@ def _filter_documents_in_memory(self, documents: list[Document], filters: dict[s
                 value = condition.get("value")
 
                 if field.startswith("meta."):
-                    meta_key = field[len("meta."):]
+                    meta_key = field[len("meta.") :]
                     doc_value = doc.meta.get(meta_key)
                 else:
                     doc_value = getattr(doc, field, None)
@@ -336,4 +348,4 @@ def from_dict(cls, data: dict[str, Any]) -> "SupabaseGroongaDocumentStore":
         :returns: Deserialized component.
         """
         deserialize_secrets_inplace(data["init_parameters"], ["supabase_key"])
-        return default_from_dict(cls, data)
+        return default_from_dict(cls, data)

integrations/supabase/tests/test_groonga_document_store.py

@@ -6,6 +6,7 @@
 
 import pytest
 from haystack.dataclasses import Document
+from haystack.document_stores.errors import DuplicateDocumentError
 from haystack.document_stores.types import DuplicatePolicy
 
 from haystack_integrations.components.retrievers.supabase import SupabaseGroongaRetriever
@@ -162,8 +163,6 @@ def test_write_documents_skip(groonga_store, mock_supabase_client):
 
 def test_write_documents_fail_on_duplicate(groonga_store, mock_supabase_client):
     """Test that FAIL policy raises error on duplicate."""
-    from haystack.document_stores.errors import DuplicateDocumentError
-
     mock_table = mock_supabase_client.table.return_value
     # simulate document already exists
     mock_table.select.return_value.eq.return_value.execute.return_value = MagicMock(data=[{"id": "existing"}])
@@ -350,4 +349,4 @@ def test_retriever_from_dict(mock_supabase_client, monkeypatch):  # noqa: ARG001
         },
     }
     retriever = SupabaseGroongaRetriever.from_dict(data)
-    assert retriever.top_k == 7
+    assert retriever.top_k == 7