renaming a missing async method + updating async tests to correct name

Author: davidsbatista

integrations/oracle/src/haystack_integrations/document_stores/oracle/document_store.py

@@ -399,7 +399,7 @@ def filter_documents(self, filters: dict[str, Any] | None = None) -> list[Docume
             rows = cur.fetchall()
         return [OracleDocumentStore._row_to_document(r) for r in rows]
 
-    async def afilter_documents(self, filters: dict[str, Any] | None = None) -> list[Document]:
+    async def filter_documents_async(self, filters: dict[str, Any] | None = None) -> list[Document]:
         return await asyncio.to_thread(self.filter_documents, filters)
 
     def delete_documents(self, document_ids: list[str]) -> None:

integrations/oracle/tests/integration/test_docker_document_store.py

@@ -293,8 +293,8 @@ def test_embedding_retrieval_with_filter(store):
 @pytest.mark.asyncio
 async def test_async_write_and_count(store):
     doc = _doc(_uid("M001"))
-    await store.awrite_documents([doc])
-    count = await store.acount_documents()
+    await store.write_documents_async([doc])
+    count = await store.count_documents_async()
     assert count >= 1
 
 
@@ -303,16 +303,16 @@ async def test_async_write_and_count(store):
 async def test_async_filter_documents(store):
     tag = _uid("N")[:8]
     doc = _doc(_uid("N001"), meta={"tag": tag})
-    await store.awrite_documents([doc])
-    results = await store.afilter_documents(filters={"field": "meta.tag", "operator": "==", "value": tag})
+    await store.write_documents_async([doc])
+    results = await store.filter_documents_async(filters={"field": "meta.tag", "operator": "==", "value": tag})
     assert len(results) == 1
 
 
 @pytest.mark.integration
 @pytest.mark.asyncio
 async def test_async_delete_documents(store):
     doc_id = _uid("O001")
-    await store.awrite_documents([_doc(doc_id)])
-    await store.adelete_documents([doc_id])
-    results = await store.afilter_documents(filters={"field": "id", "operator": "==", "value": doc_id})
+    await store.write_documents_async([_doc(doc_id)])
+    await store.delete_documents_async([doc_id])
+    results = await store.filter_documents_async(filters={"field": "id", "operator": "==", "value": doc_id})
     assert len(results) == 0

integrations/oracle/tests/integration/test_oracle_document_store.py

@@ -207,6 +207,6 @@ def test_hnsw_index_creation(store):
 async def test_async_write_and_retrieve(store):
     doc_id = uuid4().hex.upper()[:32]
     doc = Document(id=doc_id, content="async test", meta={}, embedding=[0.5, 0.5, 0.0, 0.0])
-    await store.awrite_documents([doc])
-    results = await store._async_embedding_retrieval([0.5, 0.5, 0.0, 0.0], top_k=1)
+    await store.write_documents_async([doc])
+    results = await store._embedding_retrieval_async([0.5, 0.5, 0.0, 0.0], top_k=1)
     assert len(results) >= 1

integrations/oracle/tests/unit/test_embedding_retriever.py

@@ -14,7 +14,7 @@ def mock_store():
     store = MagicMock(spec=OracleDocumentStore)
     store.distance_metric = "COSINE"
     store._embedding_retrieval.return_value = [Document(id="A" * 32, content="hi")]
-    store._async_embedding_retrieval.return_value = [Document(id="A" * 32, content="hi")]
+    store._embedding_retrieval_async.return_value = [Document(id="A" * 32, content="hi")]
     store.to_dict.return_value = {
         "type": "haystack_integrations.document_stores.oracle.document_store.OracleDocumentStore",
         "init_parameters": {
@@ -83,5 +83,5 @@ def test_to_dict_from_dict_roundtrip(mock_store, monkeypatch):
 async def test_run_async_calls_async_retrieval(mock_store):
     retriever = OracleEmbeddingRetriever(document_store=mock_store, top_k=5)
     result = await retriever.run_async(query_embedding=[0.1, 0.2, 0.3, 0.4])
-    mock_store._async_embedding_retrieval.assert_called_once()
+    mock_store._embedding_retrieval_async.assert_called_once()
     assert "documents" in result