rm tests

Author: anakin87

integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py

@@ -114,7 +114,11 @@ def _ensure_initialized(self):
             # Use dict to conditionally pass settings because Chroma doesn't accept settings=None
             client_kwargs: dict[str, Any] = {}
             if self._client_settings:
-                client_kwargs["settings"] = Settings(**self._client_settings)
+                try:
+                    client_kwargs["settings"] = Settings(**self._client_settings)
+                except ValueError as e:
+                    msg = f"Invalid client_settings ({self._client_settings}): {e}"
+                    raise ValueError(msg) from e
 
             if self._host and self._port is not None:
                 # Remote connection via HTTP client
@@ -166,7 +170,11 @@ async def _ensure_initialized_async(self):
             # Use dict to conditionally pass settings because Chroma doesn't accept settings=None
             client_kwargs: dict[str, Any] = {}
             if self._client_settings:
-                client_kwargs["settings"] = Settings(**self._client_settings)
+                try:
+                    client_kwargs["settings"] = Settings(**self._client_settings)
+                except ValueError as e:
+                    msg = f"Invalid client_settings ({self._client_settings}): {e}"
+                    raise ValueError(msg) from e
 
             client = await chromadb.AsyncHttpClient(
                 host=self._host,

integrations/chroma/tests/test_document_store.py

@@ -124,18 +124,6 @@ def test_client_settings_applied(self, clear_chroma_system_cache):
         store._ensure_initialized()
         assert store._client.get_settings().anonymized_telemetry is False
 
-    def test_invalid_client_settings_are_ignored(self, clear_chroma_system_cache):
-        store = ChromaDocumentStore(
-            client_settings={
-                "invalid_setting_name": "some_value",
-                "another_fake_setting": 123,
-            }
-        )
-        store._ensure_initialized()
-        settings = store._client.get_settings()
-        assert not hasattr(settings, "invalid_setting_name")
-        assert not hasattr(settings, "another_fake_setting")
-
     def test_to_dict(self, request):
         ds = ChromaDocumentStore(
             collection_name=request.node.name,

integrations/chroma/tests/test_document_store_async.py

@@ -107,21 +107,6 @@ async def test_client_settings_applied_async(self):
         await store._ensure_initialized_async()
         assert store._async_client.get_settings().anonymized_telemetry is False
 
-    async def test_invalid_client_settings_are_ignored_async(self):
-        store = ChromaDocumentStore(
-            host="localhost",
-            port=8000,
-            client_settings={
-                "invalid_setting_name": "some_value",
-                "another_fake_setting": 123,
-            },
-            collection_name=f"{uuid.uuid1()}-async-invalid",
-        )
-        await store._ensure_initialized_async()
-        settings = store._async_client.get_settings()
-        assert not hasattr(settings, "invalid_setting_name")
-        assert not hasattr(settings, "another_fake_setting")
-
     async def test_search_async(self):
         document_store = ChromaDocumentStore(host="localhost", port=8000, collection_name="my_custom_collection")