Skip to content

Commit 73c2bf6

Browse files
committed
fix: remove .upper() mutation on document ID in _row_to_document
Document IDs should be returned exactly as stored. The .upper() call was silently mutating lowercase or mixed-case IDs on retrieval. Addresses review feedback from @davidsbatista.
1 parent b2d3ea2 commit 73c2bf6

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • integrations/oracle/src/haystack_integrations/document_stores/oracle

integrations/oracle/src/haystack_integrations/document_stores/oracle/document_store.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ def _row_to_document(row: tuple, *, with_score: bool = False) -> Document:
484484
meta = {}
485485

486486
return Document(
487-
id=raw_id.upper(),
487+
id=raw_id,
488488
content=text,
489489
meta=meta,
490490
score=float(score) if score is not None else None,

0 commit comments

Comments
 (0)