Skip to content

Commit 87fea2f

Browse files
committed
adding to_dict/from_dict EmbeddingRetriever round trip
1 parent e25e779 commit 87fea2f

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

integrations/oracle/tests/test_embedding_retriever.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def mock_store():
2323
"init_parameters": {
2424
"connection_config": {
2525
"user": "u",
26-
"password": {"type": "token", "token": "p"},
26+
"password": {"type": "env_var", "env_vars": ["ORACLE_PASSWORD"], "strict": False},
2727
"dsn": "localhost/xe",
2828
"wallet_location": None,
2929
"wallet_password": None,
@@ -95,6 +95,13 @@ def test_to_dict_from_dict_roundtrip(mock_store):
9595
assert d["init_parameters"]["filters"] == {"field": "meta.x", "operator": "==", "value": "y"}
9696
assert d["init_parameters"]["filter_policy"] == "replace"
9797

98+
restored = OracleEmbeddingRetriever.from_dict(d)
99+
assert restored.top_k == 7
100+
assert restored.filters == {"field": "meta.x", "operator": "==", "value": "y"}
101+
assert restored.filter_policy == FilterPolicy.REPLACE
102+
assert restored.document_store.table_name == "test_docs"
103+
assert restored.document_store.embedding_dim == 4
104+
98105

99106
def test_invalid_document_store_raises_type_error():
100107
with pytest.raises(TypeError, match="must be an instance of OracleDocumentStore"):

0 commit comments

Comments
 (0)