Skip to content

Commit 91cabd9

Browse files
authored
test: Pinecone - relax flaky test (#2360)
* test: Pinecone - relax flaky test * Trigger Build
1 parent f8cc080 commit 91cabd9

2 files changed

Lines changed: 11 additions & 6 deletions

File tree

integrations/pinecone/tests/test_document_store.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ def test_embedding_retrieval(self, document_store: PineconeDocumentStore):
276276
query_embedding = [0.1] * 768
277277
most_similar_embedding = [0.8] * 768
278278
second_best_embedding = [0.8] * 700 + [0.1] * 3 + [0.2] * 65
279-
another_embedding = np.random.rand(768).tolist()
279+
another_embedding = [0.1] * 384 + [-0.1] * 384
280280

281281
docs = [
282282
Document(content="Most similar document", embedding=most_similar_embedding),
@@ -287,9 +287,11 @@ def test_embedding_retrieval(self, document_store: PineconeDocumentStore):
287287
document_store.write_documents(docs)
288288

289289
results = document_store._embedding_retrieval(query_embedding=query_embedding, top_k=2, filters={})
290+
290291
assert len(results) == 2
291-
assert results[0].content == "Most similar document"
292-
assert results[1].content == "2nd best document"
292+
# Pinecone does not seem to guarantee the order of the results
293+
assert "Most similar document" in [result.content for result in results]
294+
assert "2nd best document" in [result.content for result in results]
293295

294296
def test_close(self, document_store: PineconeDocumentStore):
295297
document_store._initialize_index()

integrations/pinecone/tests/test_document_store_async.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ async def test_embedding_retrieval(self, document_store_async: PineconeDocumentS
7070
query_embedding = [0.1] * 768
7171
most_similar_embedding = [0.8] * 768
7272
second_best_embedding = [0.8] * 700 + [0.1] * 3 + [0.2] * 65
73-
another_embedding = np.random.rand(768).tolist()
73+
another_embedding = [-0.1] * 384 + [0.1] * 384
7474

7575
docs = [
7676
Document(content="Most similar document", embedding=most_similar_embedding),
@@ -83,9 +83,12 @@ async def test_embedding_retrieval(self, document_store_async: PineconeDocumentS
8383
results = await document_store_async._embedding_retrieval_async(
8484
query_embedding=query_embedding, top_k=2, filters={}
8585
)
86+
8687
assert len(results) == 2
87-
assert results[0].content == "Most similar document"
88-
assert results[1].content == "2nd best document"
88+
89+
# Pinecone does not seem to guarantee the order of the results
90+
assert "Most similar document" in [result.content for result in results]
91+
assert "2nd best document" in [result.content for result in results]
8992

9093
async def test_close(self, document_store_async: PineconeDocumentStore):
9194
await document_store_async._initialize_async_index()

0 commit comments

Comments
 (0)